Stop IneligibleSubscriptionFilter from dropping exclusive posts on a subscription-list miss - #19
Closed
Pitchfork-and-Torch wants to merge 19 commits into
Closed
Stop IneligibleSubscriptionFilter from dropping exclusive posts on a subscription-list miss#19Pitchfork-and-Torch wants to merge 19 commits into
Pitchfork-and-Torch wants to merge 19 commits into
Conversation
in_network_ids is passed to the VF client without deduplication, while oon_ids is deduped four lines below. retweeted_tweet_id is pushed for every candidate that has one, so the same ID repeats once per retweet of a given post — most often when that post is going viral. Neither VfClient implementation dedupes its input: StratoVfClient builds one call per element, and XaiVfClient chunks by XAI_VF_MAX_BATCH_SIZE, so duplicates consume batch slots and can force an extra round trip. Not a correctness issue — results collapse into a HashMap keyed by tweet ID — but redundant work on the For You serving path. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Deduplicate in_network_ids before VF lookup
…subscription-list miss Query hydrators ignore errors, so a socialgraph miss left subscribed_user_ids empty. The mixer filter treated that as "subscribed to nobody" and dropped every exclusive post before VF. Also keep exclusive posts when the viewer is the conversation author, matching DropExclusiveTweetContentRule. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/subscription-list-miss-starve-d8a8
branch
from
September 7, 2026 04:12
e45b67e to
71ea54a
Compare
Pitchfork-and-Torch
marked this pull request as ready for review
September 7, 2026 04:31
Owner
Author
|
Wrong base (fork PR). Ship vehicle is upstream xai-org#129. Per submit law: never PR Pitchfork-and-Torch/x-algorithm. Do not merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
For You
IneligibleSubscriptionFilterdrops exclusive posts when the subscription list was never loaded, and when the viewer is the conversation author.SubscribedUserIdsQueryHydratorerrors are ignored byhydrate_query. The list stays empty. The mixer filter treated empty as “subscribed to nobody” and dropped everysubscription_author_id: Some(...)before scoring.VF
DropExclusiveTweetContentRuleallows the conversation author. The mixer filter did not.IneligibleSubscriptionFilter(phoenix_candidate_pipeline.rs)This is not xai-org#96–xai-org#120 (VF, mute/block, quote, scarecrow, geo). Brazil 2026 filter is not in this snapshot.
Fix
Mark the subscription list hydrated only after a successful socialgraph read. Keep exclusive posts when the list was not loaded. Keep exclusive posts when the viewer is the conversation author.
A hydrated empty list still drops exclusive posts for everyone except the conversation author.
Tests
Filter unit tests cover hydrator-miss keep, conversation-author keep, subscribed keep, unsubscribed drop, and hydrated-empty drop. Hydrator tests cover success marking the list ready and errors leaving it unready.
cargo: cannot run the Home Mixer crate here. Public dump has no Home Mixer manifest. Standalone keep-rule check: 6/6 passed.