Limit Brazil 2026 election filter to BR request country - #20
Closed
Pitchfork-and-Torch wants to merge 19 commits into
Closed
Limit Brazil 2026 election filter to BR request country#20Pitchfork-and-Torch wants to merge 19 commits into
Pitchfork-and-Torch wants to merge 19 commits into
Conversation
in_network_ids is passed to the VF client without deduplication, while oon_ids is deduped four lines below. retweeted_tweet_id is pushed for every candidate that has one, so the same ID repeats once per retweet of a given post — most often when that post is going viral. Neither VfClient implementation dedupes its input: StratoVfClient builds one call per element, and XaiVfClient chunks by XAI_VF_MAX_BATCH_SIZE, so duplicates consume batch slots and can force an extra round trip. Not a correctness issue — results collapse into a HashMap keyed by tweet ID — but redundant work on the For You serving path. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Deduplicate in_network_ids before VF lookup
Art. 28 § 1º-A is a Brazil recommendation rule. The filter applied the Electoral Court list to every viewer. Known non-BR country_code now skips it. Empty or missing country still applies so a geo miss cannot turn the list off. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
Pitchfork-and-Torch
marked this pull request as ready for review
September 7, 2026 04:31
Owner
Author
|
Wrong base (fork PR). Ship vehicle is upstream xai-org#130. Per submit law: never PR Pitchfork-and-Torch/x-algorithm. Do not merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Brazil2026ElectionFilterruns for every For You viewer. It has no country check.The list is the TSE 2026 Electoral Court set (Art. 28 § 1º-A of Resolution 23.610). That rule is for recommendation in Brazil.
query.country_codeis already on the request. The filter ignored it, so about 2554 listed accounts were dropped from For You worldwide.Not the listed-viewer self-id hole (#53).
is_excluded_authorand the follow exception are unchanged.OON SimClusters NSFW gate (survey)
OONNsfwSimclustersFilterwas checked after the gizmoduck origin NSFW change (xai-org#125).nsfw_author. After home-mixer: use origin author for size and NSFW, fail closed on gizmoduck miss xai-org/x-algorithm#125 that flag is the OR of poster, original, and quoted, and a store miss is labeled.in_network == Some(false)is the poster follow bit. That is correct. In-network NSFW is a VF interstitial, not a drop.nsfw_author == Some(true)fail-opens onNone. On the live SimClusters path, gizmoduck is on and home-mixer: use origin author for size and NSFW, fail closed on gizmoduck miss xai-org/x-algorithm#125 always writesSome. Simclusters retrieval and gizmoduck both skip whenhas_cached_posts.No remaining correctness bug in that filter after xai-org#125.
Fix
One file,
home-mixer/filters/brazil_2026_election_filter.rs.country_codeisBR/br.Tests
bris in scope.home-mixerhas no public Cargo manifest. The geo gate was compiled and run as a rustc model: passed.Lane:
home-mixer/filters/brazil_2026_election_filter.rsonly. Based onxai-org/x-algorithmmain.