Stop CoreData from skipping TES on NightOwl replies and retweets - #22
Closed
Pitchfork-and-Torch wants to merge 20 commits into
Closed
Stop CoreData from skipping TES on NightOwl replies and retweets#22Pitchfork-and-Torch wants to merge 20 commits into
Pitchfork-and-Torch wants to merge 20 commits into
Conversation
in_network_ids is passed to the VF client without deduplication, while oon_ids is deduped four lines below. retweeted_tweet_id is pushed for every candidate that has one, so the same ID repeats once per retweet of a given post — most often when that post is going viral. Neither VfClient implementation dedupes its input: StratoVfClient builds one call per element, and XaiVfClient chunks by XAI_VF_MAX_BATCH_SIZE, so duplicates consume batch slots and can force an extra round trip. Not a correctness issue — results collapse into a HashMap keyed by tweet ID — but redundant work on the For You serving path. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Deduplicate in_network_ids before VF lookup
Pitchfork-and-Torch
marked this pull request as ready for review
September 7, 2026 04:20
NightOwl already sets author_id and tweet_text, so CoreData treated Latest Following cards as hydrated and never filled ancestor_users or retweeted_user_id. SelfReplyChainFilter then fail-opened. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
Regression: author+text originals still use the NightOwl payload and do not pick up TES text. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/nightowl-coredata-skip-tes-0ca8
branch
from
September 7, 2026 04:22
4e0cc2b to
663e316
Compare
Owner
Author
|
Wrong base (fork PR). Ship vehicle is upstream xai-org#132. Per submit law: never PR Pitchfork-and-Torch/x-algorithm. Do not merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased onto latest
xai-org/x-algorithmmain(902a06f). Dropped fork-only commits so upstream xai-org#132 is a 1-file change.Bug
Latest Following (NightOwl) pre-fills
author_idandtweet_text.CoreDataCandidateHydrator.already_hydratedtreated that as done and skipped TES.NightOwl does not set
ancestor_usersorretweeted_user_id.SelfReplyChainFilterfail-opens whenancestor_usersis empty, so self-replies aimed at an unfollowed user stay in Following.reverse_chron_posts_pipelineruns CoreData, thenSelfReplyChainFilter. The filter order is fine. The hydrator never filled the field the filter reads.Concrete case: viewer follows B, not C. B self-replies in C's thread. NightOwl returns the reply (
in_reply_to_tweet_idset,ancestorsset,ancestor_usersempty). CoreData skips TES. Filter keeps the card.Not xai-org#94 (TES miss wiping Thunder/Phoenix ids). Not xai-org#99 (For You self-reply chains). Not xai-org#102 / xai-org#97 (conversation-gap grandparents). Related to but distinct from CoreData stale author overwrite (xai-org#131 / fork #21); that
update()overwrite is not onxai-org/mainand is left alone.Fix
Call TES when a reply still has empty
ancestor_users, or a retweet still has noretweeted_user_id. Originals with author and text still skip TES.On TES miss, keep the source fields. An empty default would clear NightOwl reply/retweet ids now that TES runs for those cards.
Tests
ancestor_users; filter then drops the unfollowed-root self-replyretweeted_user_idon a NightOwl retweetHome Mixer has no public Cargo manifest, so
cargo teststill needs X's build. Predicates foralready_hydratedandSelfReplyChainFilterwere checked against the same cases.