Stop Latest Following from ignoring hide-replies and hide-links - #36
Closed
Pitchfork-and-Torch wants to merge 19 commits into
Closed
Stop Latest Following from ignoring hide-replies and hide-links#36Pitchfork-and-Torch wants to merge 19 commits into
Pitchfork-and-Torch wants to merge 19 commits into
Conversation
in_network_ids is passed to the VF client without deduplication, while oon_ids is deduped four lines below. retweeted_tweet_id is pushed for every candidate that has one, so the same ID repeats once per retweet of a given post — most often when that post is going viral. Neither VfClient implementation dedupes its input: StratoVfClient builds one call per element, and XaiVfClient chunks by XAI_VF_MAX_BATCH_SIZE, so duplicates consume batch slots and can force an extra round trip. Not a correctness issue — results collapse into a HashMap keyed by tweet ID — but redundant work on the For You serving path. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Deduplicate in_network_ids before VF lookup
QueryBuilder copied exclude_videos but never hide_replies / hide_links / exclude_replies / exclude_retweets. Night Owl always include:retweets and never applied -filter:replies or -filter:links, so those viewer preferences were a no-op on Latest Following. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Latest Following copies
exclude_videos(xai-org#120) and still ignores the rest of the viewer content-controls.QueryBuilder never copied
hide_replies/hide_links/exclude_replies/exclude_retweets. Night Owl always searched withinclude:retweetsand never applied-filter:repliesor-filter:links. Reverse-chron filters were RT-dedup, muted keyword, and self-reply. Hide-replies and hide-links were a no-op.Ranked Following / For You already have
VideoFilterfor hide-videos. They had no reply/link/retweet content-control filter either; the same mixer filter is wired next toVideoFilter.This is not xai-org#120 (hide-videos / MediaInfo). Not xai-org#98 (quoted video duration). Not xai-org#99 / xai-org#132 (self-reply chains).
Five-line proof
QueryBuilder(server.rs) and Night Owlold_query(following_night_owl_source.rs)FollowingContentControlsFilteronReverseChronPostsPipeline(and Phoenix next toVideoFilter)include:retweetsexclude_videosis already copied andVideoFilteralready exists (Stop Latest Following from ignoring hide-videos xai-org/x-algorithm#120)Change
hide_replies,hide_links,exclude_replies,exclude_retweetsontoScoredPostsQuery-filter:replies,-filter:links, and-filter:nativeretweetswhen those flags are setTests
www.host, keepsnotwwwinclude:retweets; flags composeStandalone decision-table harness (same match arms): 19/19 passed.
cargo testcannot run. Public dump has no Home Mixer manifest.Leftover
For You cached-posts Redis key still keys only on
exclude_videos. A cache hit can still contain replies/links; the new Phoenix filter drops them after the hit (slate may underfill). Same class as xai-org#98 leftover for quoted duration on cache.Fork PR: none