Stop WhoToFollow from recommending muted or blocked accounts - #37
Closed
Pitchfork-and-Torch wants to merge 19 commits into
Closed
Stop WhoToFollow from recommending muted or blocked accounts#37Pitchfork-and-Torch wants to merge 19 commits into
Pitchfork-and-Torch wants to merge 19 commits into
Conversation
in_network_ids is passed to the VF client without deduplication, while oon_ids is deduped four lines below. retweeted_tweet_id is pushed for every candidate that has one, so the same ID repeats once per retweet of a given post — most often when that post is going viral. Neither VfClient implementation dedupes its input: StratoVfClient builds one call per element, and XaiVfClient chunks by XAI_VF_MAX_BATCH_SIZE, so duplicates consume batch slots and can force an extra round trip. Not a correctness issue — results collapse into a HashMap keyed by tweet ID — but redundant work on the For You serving path. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Deduplicate in_network_ids before VF lookup
SGS mute/block list hydrators now mark the query ready only on a successful read. For You and Latest Following blender pipelines load those lists. WhoToFollow stays disabled until both lists are ready and sends muted/blocked ids in excluded_user_ids ahead of fatigue ids. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
WhoToFollow
excluded_user_idsonly sent previously shown WTF accounts. It never sent muted or blocked user ids.For You and Latest Following blender pipelines never loaded those SGS lists. Phoenix loads them for post filters only. WTF runs at the blender layer, so VF never sees the recommended accounts.
SGS
get_muted_user_ids/get_blocked_user_idsErr is ignored by query hydration (updateis skipped). Empty lists look like "muted nobody".This is not xai-org#137 (VF primary-author relationship Failed). This is not #23 / xai-org#140 (quoted-author mute on posts). ListTimeline / ListLatest are not in this dump.
Five-line proof
MutedUserIdsQueryHydrator/BlockedUserIdsQueryHydrator(SGS list membership). For You / Latest Following blender queries never ran them.WhoToFollowSource::get_excluded_user_ids→ ARMWhoToFollowReactiveContext.excluded_user_idsFollowingRepliedUsersHydratoralready excludes muted+blocked ids;AuthorSocialgraphFilteralready uses the same lists for postsChange
excluded_user_idsputs muted/blocked ids first, then fatigue ids.Genuine empty lists (viewer muted/blocked nobody) still enable the module.
Tests
updatesets the ready flagStandalone decision-table harness (same exclude / ready arms): 8/8 passed.
cargo testcannot run. Public dump has no Home Mixer manifest.Leftover
Mixer
AuthorSocialgraphFilterstill treats an unready empty list as nobody muted/blocked for quoted/RT authors. After xai-org#137, VF is the sink for primary-author mute/block. WTF has no VF sink.Fork PR: none