Apply original-tweet civic labels when scoring retweets - #43
Closed
Pitchfork-and-Torch wants to merge 19 commits into
Closed
Apply original-tweet civic labels when scoring retweets#43Pitchfork-and-Torch wants to merge 19 commits into
Pitchfork-and-Torch wants to merge 19 commits into
Conversation
in_network_ids is passed to the VF client without deduplication, while oon_ids is deduped four lines below. retweeted_tweet_id is pushed for every candidate that has one, so the same ID repeats once per retweet of a given post — most often when that post is going viral. Neither VfClient implementation dedupes its input: StratoVfClient builds one call per element, and XaiVfClient chunks by XAI_VF_MAX_BATCH_SIZE, so duplicates consume batch slots and can force an extra round trip. Not a correctness issue — results collapse into a HashMap keyed by tweet ID — but redundant work on the For You serving path. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Deduplicate in_network_ids before VF lookup
VF hydrated safety labels only for the requested wrapper id. A civic-integrity label on the original never reached FosnrCivicIntegrityDropRule, so Following and in-network For You kept the retweet. Fetch the source tweet's labels, union them onto the wrapper, and fail closed when that read is Err or omitted. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
Owner
Author
|
Wrong base (fork PR). Do not merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
VF
SafetyLabelHydratorlooks up labels only for the requested tweet ids. A retweet wrapper hassource_tweet_idafter TES, but civic / FOSNR / misinfo labels live on the original.FosnrCivicIntegrityDropRulecheckshas_safety_labelon the wrapper, so Following and in-network For You keep a retweet of a civic-integrity labeled post.UTH says FOSNR_CIVIC_INTEGRITY restricts discoverability to the author's profile. Hate / abuse / violent-speech stay on TimelineHome for the same reason. This is not xai-org#109 (civic table move to OON). This is not xai-org#115 (Following quotes at TimelineHome). This is not xai-org#119 (home-mixer primary lookup by wrapper id). This is not xai-org#121 / xai-org#139 (primary VF or wrapper label Err).
When the original is not in the same VF batch, the source label read was never issued. When it is issued and returns Err or omits the id, this change fails closed (omit wrapper →
unresolved_authorDrop). Confirmed-empty original stays unlabeled.Five-line proof
HydrationPipeline::hydrate/apply_source_tweet_safety_labels(TESsource_tweet_id)FosnrCivicIntegrityDropRule→VFFilterAction::Drop/PossiblyUndesirableAdsBrandSafetyVfHydratoralready usesretweeted_tweet_id.unwrap_or(tweet_id)Survey (xai-org#96–xai-org#142)
source_tweet_id.Tests
retweet_inherits_confirmed_civic_label_from_originalretweet_source_label_err_fails_closed(fails open on unmodified main: source never fetched)confirmed_unlabeled_original_does_not_fail_closedcivic_integrity_retweet_with_source_label_drops/ golden corpus Home + Recsunion_adds_civic_without_dropping_existingcargo testcannot run. Public dump has no VF crate manifest.Fork PR: none