Fail closed when TES media or URL entity lookup is missing - #44
Closed
Pitchfork-and-Torch wants to merge 19 commits into
Closed
Fail closed when TES media or URL entity lookup is missing#44Pitchfork-and-Torch wants to merge 19 commits into
Pitchfork-and-Torch wants to merge 19 commits into
Conversation
in_network_ids is passed to the VF client without deduplication, while oon_ids is deduped four lines below. retweeted_tweet_id is pushed for every candidate that has one, so the same ID repeats once per retweet of a given post — most often when that post is going viral. Neither VfClient implementation dedupes its input: StratoVfClient builds one call per element, and XaiVfClient chunks by XAI_VF_MAX_BATCH_SIZE, so duplicates consume batch slots and can force an extra round trip. Not a correctness issue — results collapse into a HashMap keyed by tweet ID — but redundant work on the For You serving path. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Deduplicate in_network_ids before VF lookup
TES media Ok(None) assembled as has_media=false, so NSFW_HIGH_PRECISION age-gating and author interstitial skipped. Fetch URL entities and drop candidates whose media slot is NotFound/Failed or whose URL RPC failed. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
TES
get_tweet_media_entitiesOk(None)/ Failed assembled ashas_media=falseviaget_or_default.nsfw_base_conditionandNsfwAuthorInterstitialRulerequirehas_media(), so NSFW_HIGH_PRECISION age-gating and author interstitial skipped.get_urlswas never called, so a card URL RPC miss was invisible.This is not xai-org#104 (bot 7429 cleanup). This is not xai-org#107 (GetTweetLabelInfoFromURL RTF reads). This is not xai-org#139 (SafetyLabelHydrator empty map). This is not xai-org#134 (TES flag Failed only; that leftover left media NotFound as no-media).
Found(empty) is a confirmed no-media / no-card tweet. That path is unchanged.
Five-line proof
TesHydrator::hydrate_tweets(get_tweet_media_entities, now alsoget_urls)retain_candidates_with_usable_media_or_url_entitiesomit →FilterTweetsVerdict::unresolved_authorDropChange
Drop a candidate when the media slot is NotFound, Failed, or missing. Fetch URL entities; drop on URL Failed. Confirmed empty media/URL lists still assemble and serve.
Tests
Standalone decision-table harness (same match arms): 12/12 passed.
cargo testcannot run. Public dump has no visibility-filtering crate manifest.Fork PR: none