Stop Community Notes from burying organic For You rank - #58
Closed
Pitchfork-and-Torch wants to merge 19 commits into
Closed
Stop Community Notes from burying organic For You rank#58Pitchfork-and-Torch wants to merge 19 commits into
Pitchfork-and-Torch wants to merge 19 commits into
Conversation
in_network_ids is passed to the VF client without deduplication, while oon_ids is deduped four lines below. retweeted_tweet_id is pushed for every candidate that has one, so the same ID repeats once per retweet of a given post — most often when that post is going viral. Neither VfClient implementation dedupes its input: StratoVfClient builds one call per element, and XaiVfClient chunks by XAI_VF_MAX_BATCH_SIZE, so duplicates consume batch slots and can force an extra round trip. Not a correctness issue — results collapse into a HashMap keyed by tweet ID — but redundant work on the For You serving path. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Deduplicate in_network_ids before VF lookup
NSFA_COMMUNITY_NOTE was ads MediumRisk. partition_organic and time_gap treat MediumRisk as avoid and pull those posts out of Phoenix order. A crowd note is context, not brand-unsafe inventory. Remove it from v1 and v2 MediumRisk so a noted post keeps its rank. Real NSFW/NSFA and unscored posts stay MediumRisk. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Community Notes were ads MediumRisk.
NSFA_COMMUNITY_NOTEsat inMEDIUM_RISK_LABELSandMEDIUM_RISK_LABELS_V2. AdsBrandSafetyVfHydrator writes that verdict onto the shared post.has_avoidtreats MediumRisk as ads-avoid. Default For You blenders (partition_organic,time_gap) then pull avoid posts out of Phoenix order and dump them into filler after the ad sandwich.A reply or quote inherits the worst ancestor/quoted verdict. A note on the parent buried the whole conversation when ads placed.
This is not xai-org#127 (missing verdict /
nsfw_author_adsleaking MediumRisk). xai-org#127 keeps real MediumRisk off ad neighbors. A crowd note is not brand-unsafe inventory. VF does not dropNSFA_COMMUNITY_NOTE. Phoenix does not score it. Ads taxonomy was the only rank writer.Fix
Remove
NSFA_COMMUNITY_NOTEfrom v1 and v2 MediumRisk. A Grok-safe noted post stays Safe. Real NSFW/NSFA and unscored posts stay MediumRisk.Proof
Tests