Stop DedupConversationFilter from keeping retweets of mid-thread replies - #71
Closed
Pitchfork-and-Torch wants to merge 1 commit into
Closed
Stop DedupConversationFilter from keeping retweets of mid-thread replies#71Pitchfork-and-Torch wants to merge 1 commit into
Pitchfork-and-Torch wants to merge 1 commit into
Conversation
Retweets without ancestors keyed to the original tweet id, so a retweet of a reply stayed in a different bucket than the rest of that conversation. Map originals onto the min-ancestor root already present on the slate. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DedupConversationFilter keys replies by
min(ancestors)and retweets with empty ancestors byget_original_tweet_id(). That only collapses a retweet of the root. A retweet of a mid-thread reply keys to the reply id, so the RT and the rest of the thread both survive post-selection.Proof
[2, 1]keys to 11; the reply keys to 1retweeted_tweet_id == min(ancestors)); Thunder fills ancestors on replies, not on retweetsThis is not xai-org#97/xai-org#102 (gap expansion / unhydrated grandparents). Not xai-org#99 (self-reply chains). Not xai-org#101/xai-org#111 (muted/blocked ancestors). Not xai-org#179 (seen/served parent). Not xai-org#180 (Phoenix VF parents).
Fix: before scoring, map each slate tweet/ancestor onto the smallest conversation root already present. Retweets without ancestors use that root when the original is on the slate (as a reply or as someone’s ancestor). Unrelated originals stay on their own tweet id. Replies still key by
min(ancestors), so shallow[2]vs[2, 1]stays two conversations.Tests: RT of the reply itself, RT of a reply listed as a sibling ancestor, unrelated RT unchanged, existing root-RT and multi-conversation cases unchanged.
cargo test cannot run here. Public dump has no Home Mixer manifest. Standalone rustc model of old vs new keying passed 4/4.