Stop VF from serving posts with global TES takedowns - #76
Closed
Pitchfork-and-Torch wants to merge 1 commit into
Closed
Stop VF from serving posts with global TES takedowns#76Pitchfork-and-Torch wants to merge 1 commit into
Pitchfork-and-Torch wants to merge 1 commit into
Conversation
DropGlobalTakendownPostRule consumes post-level DMCA, hateful imagery, unknown reasons, and TES has_takedown when no country reason is attached. Country-scoped legal/local-law rows stay on the existing geo rules. Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
TES hydrates
TakedownFeature.appliedfromget_has_takedownand storesTakedownReason::Dmca,HatefulImagery, andUnknown. No VF rule reads those signals.DropLegalTakendownPostRule/DropLocalLawsTakendownPostRuleonly extract country codes fromLegalRequest,UnspecifiedReason, andBystanderReport. The existing testtakedown_rules_ignore_non_country_reasonsasserts DMCA / hateful imagery / unknown Allow on those two rules.TakedownFeature.appliedis written and never read.This is not xai-org#187 (media-level
has_dmca_media/ geo lists, recommendation-only wiring). This is not xai-org#134 (TES RPC fail-closed). This is not xai-org#148 (withheld country list). This is not xai-org#113 (account vs request country).Proof
TesHydrator::build_tweet_featureswritestakedown.appliedandtakedown.reasons.Policies::evaluate/base_home_rules()— no rule readsappliedor the global reason variants.Dmca/HatefulImagery/Unknown;appliedhas no consumer.has_takedown=truewith no country reason, is Allowed on TimelineHome and TimelineHomeRecommendations (Following and For You).LegalRequest/BystanderReportalready drop in the matching viewer country. Media-level DMCA is a different row (DropTweetsWithDmcaMediaRule). Stop TimelineHome from serving DMCA and geo-restricted media xai-org/x-algorithm#187's own twin claimed post-levelTakedownReason::Dmcaalready drops on TimelineHome — it does not.Fix
Add
DropGlobalTakendownPostRuletobase_home_rulesafter the country takedown rules.Drop when reasons include
Dmca,HatefulImagery, orUnknown, or whenappliedis true and no country-scoped reason is present (leave those to the geo rules). Does not consume media-levelhas_dmca_media.Tests
global_takedown_drops_dmca(fails on unmodified main)global_takedown_drops_hateful_imageryglobal_takedown_drops_unknownglobal_takedown_drops_applied_with_no_country_reasonglobal_takedown_allows_country_only_legal_requestglobal_takedown_drops_even_for_authorglobal_takedown_does_not_consume_media_dmca(fails if this twins Stop TimelineHome from serving DMCA and geo-restricted media xai-org/x-algorithm#187)post_level_dmca_drops_on_timeline_hometes_has_takedown_applied_drops_on_timeline_hometakedown_rules_ignore_non_country_reasonsstill Allows the two geo rules; now Drops on the new ruleSurvey: xai-org#96-xai-org#193. Unclaimed. Not steward ads/Explore/soft-demotion/NaN. Not xai-org#187 media DMCA wiring.