Conversation
w-le
approved these changes
Jul 24, 2026
w-le
left a comment
w-le
left a comment
Contributor
There was a problem hiding this comment.
Intention looks good to me. Execution looks good in my limited understanding of the code.
Side question: The CI/test/* gh actions on this repo have been failing since June 19. How can we tell whether this PR still passes all the tests?
Contributor
Author
Validate that specs part of PR are not failing. CI is flaky due to the fact that test suite relies on many other components/services and things get tricky in GH actions. Local machines you should be seeing all specs as green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.