🛡️ Sentinel: Fix SSRF vulnerability in WebsiteVerificationService - #10
Pmaster-dev wants to merge 2 commits into
Conversation
Implement URL scheme and host validation to prevent Server-Side Request Forgery (SSRF) when verifying project website URLs. Block local/private IP subnets, loopback addresses, cloud metadata endpoints, and non-HTTP protocols. Co-authored-by: Pmaster-dev <293764797+Pmaster-dev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Add URL scheme and host validation to WebsiteVerificationService to mitigate SSRF - Fix invalid actions/setup-node@v6 action references in workflow files to use @v4 Co-authored-by: Pmaster-dev <293764797+Pmaster-dev@users.noreply.github.com>
This branch has not been deployed
1 participant
🚨 Severity: HIGH
💡 Vulnerability: Server-Side Request Forgery (SSRF) in WebsiteVerificationService
🎯 Impact: Attackers could send requests to internal endpoints, loopback servers, or cloud metadata services (169.254.169.254).
🔧 Fix: Implemented
isSafeUrlcheck inWebsiteVerificationService.tsto validate protocols (HTTP/HTTPS) and restrict internal/private IPv4/IPv6 address subnets and local domain names.✅ Verification: Created unit tests in
server/services/WebsiteVerificationService.test.tsverifying that unsafe URLs are correctly blocked.PR created automatically by Jules for task 18407376443543360044 started by @Pmaster-dev