Skip to content

🛡️ Sentinel: Fix Open Redirect vulnerability & sensitive OAuth log leakage - #12

Open
Pmaster-dev wants to merge 2 commits into
mainfrom
jules-3753255979249777627-20ad620a
Open

Pmaster-dev wants to merge 2 commits into
mainfrom
jules-3753255979249777627-20ad620a

Conversation

@Pmaster-dev

Copy link
Copy Markdown
Owner

Fixes an Open Redirect vulnerability and sensitive data logging issue in server/api/v1/auth.ts:

  1. Removes logging of raw req.query in /api/v1/auth/callback to prevent leaking OAuth authorization codes in server logs.
  2. Implements sanitizeRedirectUrl() to enforce relative-path-only redirects and prevent protocol-relative or backslash open redirect attacks.
  3. Added unit tests in server/api/v1/auth.test.ts covering redirect URL sanitization.

PR created automatically by Jules for task 3753255979249777627 started by @Pmaster-dev

Fix open redirect vulnerability in OAuth callback handler by
sanitizing redirectUrl to relative paths only. Remove direct query
logging to prevent sensitive authorization code leakage in logs.

Co-authored-by: Pmaster-dev <293764797+Pmaster-dev@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Fix open redirect vulnerability in OAuth callback handler by
sanitizing redirectUrl to relative paths only. Remove direct query
logging to prevent sensitive authorization code leakage in logs.

Co-authored-by: Pmaster-dev <293764797+Pmaster-dev@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant