Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix SSRF in Website Verification Service - #17

Open
Pmaster-dev wants to merge 2 commits into
mainfrom
sentinel/fix-ssrf-website-verification-7898723389904156116
Open

Pmaster-dev wants to merge 2 commits into
mainfrom
sentinel/fix-ssrf-website-verification-7898723389904156116

Conversation

@Pmaster-dev

Copy link
Copy Markdown
Owner

🚨 Severity: HIGH
πŸ’‘ Vulnerability: Server-Side Request Forgery (SSRF) in WebsiteVerificationService
🎯 Impact: Attackers could submit local loopback addresses (127.0.0.1, localhost), private IP subnets (10.x, 172.16-31.x, 192.168.x), or Cloud metadata endpoints (169.254.169.254) to scan internal services or extract sensitive cloud credentials.
πŸ”§ Fix: Added URL scheme and hostname validation (isSafeUrl) in WebsiteVerificationService to reject non-public and private/internal IP addresses before performing HTTP GET requests.
βœ… Verification: Added unit tests in server/services/WebsiteVerificationService.test.ts verifying that loopback addresses, AWS metadata, and private IP ranges are rejected.


PR created automatically by Jules for task 7898723389904156116 started by @Pmaster-dev

Validate URL hostnames in WebsiteVerificationService to block loopback,
private IP networks, and cloud metadata endpoints.

Co-authored-by: Pmaster-dev <293764797+Pmaster-dev@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Validate URL hostnames in WebsiteVerificationService to block loopback,
private IP networks, and cloud metadata endpoints.

Co-authored-by: Pmaster-dev <293764797+Pmaster-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant