π‘οΈ Sentinel: [HIGH] Fix hardcoded HMAC secret in webhook signing - #18
Pmaster-dev wants to merge 2 commits into
Conversation
Replace hardcoded 'idsec_secret_salt' in server/routes.ts with WEBHOOK_SECRET or JWT_SECRET environment variables to prevent webhook signature forgery. Co-authored-by: Pmaster-dev <293764797+Pmaster-dev@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Replace hardcoded 'idsec_secret_salt' in server/routes.ts with WEBHOOK_SECRET or JWT_SECRET environment variables to prevent webhook signature forgery. Co-authored-by: Pmaster-dev <293764797+Pmaster-dev@users.noreply.github.com>
π¨ Severity: HIGH
π‘ Vulnerability: Hardcoded HMAC secret salt (
"idsec_secret_salt") used to generate SHA-256 signatures for webhook payloads.π― Impact: Attackers could forge valid HMAC signatures and bypass payload authenticity verification.
π§ Fix: Replaced hardcoded secret with
process.env.WEBHOOK_SECRET || process.env.JWT_SECRETand added fail-safe validation.β Verification: Code review verified and
read_fileconfirmed clean diff under 50 lines.PR created automatically by Jules for task 4231734867711835847 started by @Pmaster-dev