🛡️ Sentinel: Fix hardcoded HMAC secret salt in webhook payload calculation - #21
Pmaster-dev wants to merge 2 commits into
Conversation
- Replace hardcoded "idsec_secret_salt" string in webhook signature generation with process.env.IDSEC_HMAC_SECRET with fallback. - Add security explanation comments. - Add unit test for webhook HMAC signature calculation. Co-authored-by: Pmaster-dev <293764797+Pmaster-dev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Replace hardcoded "idsec_secret_salt" string in webhook signature generation with process.env.IDSEC_HMAC_SECRET with fallback. - Add security explanation comments. - Add unit test for webhook HMAC signature calculation. Co-authored-by: Pmaster-dev <293764797+Pmaster-dev@users.noreply.github.com>
1 participant
Replaced hardcoded HMAC salt secret in webhook test process route with IDSEC_HMAC_SECRET environment variable fallback and added unit test.
PR created automatically by Jules for task 12845697335483272810 started by @Pmaster-dev