🛡️ Sentinel: Fix information disclosure in login_required decorator - #20
Pmaster-dev wants to merge 1 commit into
Conversation
Remove exception string details (`str(e)`) from `login_required` error response in `auth/utils.py` to prevent leaking internal error or system details to unauthenticated callers. Add test suite in `tests/test_auth_utils.py` verifying error messages do not disclose internal exception details. Co-authored-by: Pmaster-dev <293764797+Pmaster-dev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🛡️ Sentinel: Fix information disclosure in login_required decorator
🚨 Severity: MEDIUM
💡 Vulnerability: Exposing internal exception string details (
str(e)) inlogin_requiredJSON response upon authentication failure or error.🎯 Impact: Unauthenticated callers could gain sensitive information about internal system architecture, database errors, or internal state.
🔧 Fix: Omit exception details from the
401 UnauthorizedJSON response.✅ Verification: Added unit tests in
tests/test_auth_utils.pyand ranpython3 -m pytest.PR created automatically by Jules for task 4866819276435076816 started by @Pmaster-dev