π‘οΈ Sentinel: Fix hardcoded JWT secret fallback - #21
Pmaster-dev wants to merge 1 commit into
Conversation
Co-authored-by: Pmaster-dev <293764797+Pmaster-dev@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: Fallback to static 'jwt-secret' when JWT_SECRET_KEY environment variable is not set.
π― Impact: Attackers could forge or decode JWT tokens if JWT_SECRET_KEY environment variable is missing.
π§ Fix: Require JWT_SECRET_KEY to be set in environment and raise ValueError if missing or empty in JWTUtils.
β Verification: Added unit tests in tests/test_auth_utils.py ensuring missing JWT_SECRET_KEY raises ValueError and token operations succeed when set.
PR created automatically by Jules for task 4755741623692660761 started by @Pmaster-dev