π‘οΈ Sentinel: Fix authorization bypass for cached inactive users - #24
Conversation
β¦ responses Co-authored-by: Pmaster-dev <293764797+Pmaster-dev@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: User records retrieved from Redis cache in
@login_requiredbypassedis_activevalidation, allowing deactivated or inactive users with cached entries to access protected routes. Furthermore, unauthorized error responses leaked raw exception strings (str(e)).π― Impact: Inactive accounts could bypass access controls. Raw exception details could leak internal database or cache error information to clients.
π§ Fix: Validated
is_activestatus on cached user data before authorizing requests and removed internal exception details from 401 error responses. Added comprehensive unit test coverage intests/test_auth_utils.py.β Verification: Ran
pytest(7 passed) andpylint(score 7.92/10).PR created automatically by Jules for task 17842397545404611078 started by @Pmaster-dev