🛡️ Sentinel: Fix JWT secret key enforcement and sanitize auth error responses - #27
Conversation
- Require JWT_SECRET_KEY environment variable in JWTUtils rather than falling back to hardcoded default key - Remove internal exception detail leakage in login_required decorator - Add unit tests for auth utils with cache_db mock Co-authored-by: Pmaster-dev <293764797+Pmaster-dev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Fixes critical security vulnerabilities in
auth/utils.pyby requiringJWT_SECRET_KEYto be configured in the environment (preventing JWT token forgery via default fallback secrets) and sanitizinglogin_requirederror responses to avoid leaking internal exception details. Includes unit tests covering these changes.PR created automatically by Jules for task 269067716081934174 started by @Pmaster-dev