🛡️ Sentinel: Fix info leak in login_required decorator - #30
Pmaster-dev wants to merge 1 commit into
Conversation
Remove exception details from 401 response in login_required decorator to prevent exposing sensitive internal system info. Co-authored-by: Pmaster-dev <293764797+Pmaster-dev@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🛡️ Sentinel Security Fix
login_requiredwas returningstr(e)in the 401 JSON error payload ({'error': 'Unauthorized', 'details': str(e)}), leaking internal system/database/Redis exception details to unauthenticated callers.details: str(e)from the 401 response and logged exceptions server-side usinglogger.error(...).tests/test_auth.pyasserting that HTTP 401 responses do not leak exception details or internal connection/database details. All pytest tests pass and pylint score is 8.14/10.PR created automatically by Jules for task 17031911915626781729 started by @Pmaster-dev