Support eth account subsidy - #1995
Open
Neopallium wants to merge 13 commits into
Open
Conversation
Neopallium
requested review from
HenriqueNogara
and
a lite review from Copilot
August 21, 2026 16:58
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Ethereum-account support to Polymesh fee subsidization and MultiSig flows by routing ETH-originated calls through pallet_revive, extending transaction-payment/subsidy accounting to include pre-charged storage deposits, and tightening operational tipping permissions (GC-only).
Changes:
- Extend
ChargeTransactionPaymentto account for (ETH) pre-charged storage deposits when reserving/settling subsidy usage. - Update runtime call routing / filtering to handle nested
Revive::eth_substrate_calland add ETH extrinsic conversion logic. - Update tests (runtime + integration) to cover ETH wallet subsidy usage and ETH MultiSig signer behavior; remove DID-registrar tipping support.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pallets/transaction-payment/src/lib.rs | Track storage deposit alongside fee/tip for subsidy reserve/settlement and remove DID-registrar-based tipping. |
| pallets/transaction-payment/src/benchmarking.rs | Update bounds to account for new credit/imbalance types. |
| pallets/transaction-payment/Cargo.toml | Dependency formatting + add log. |
| pallets/runtime/tests/src/transaction_payment_test.rs | Adjust tipping tests to GC-only behavior. |
| pallets/runtime/tests/src/signed_extra.rs | Add GC membership genesis setup for tipping rules in tests. |
| pallets/runtime/common/src/runtime.rs | Handle nested Revive::eth_substrate_call, call filtering, and ETH extrinsic decoding/fee+storage precharge plumbing. |
| pallets/permissions/Cargo.toml | Dependency formatting + add log. |
| integration/tests/relayer.rs | Add coverage for subsidized calls and ETH wallet subsidy flow. |
| integration/tests/multisig_permissions.rs | Add integration test verifying ETH wallet can act as a MultiSig signer via pallet_revive interface. |
| Cargo.lock | Lockfile updates for dependency revisions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Neopallium
force-pushed
the
support_eth_account_subsidy
branch
from
August 21, 2026 17:29
4045e6f to
a96b998
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog
new features
other