feat(inbox): clarify agent-session actions and gate them on personal GitHub#2615
Draft
Twixes wants to merge 1 commit into
Draft
feat(inbox): clarify agent-session actions and gate them on personal GitHub#2615Twixes wants to merge 1 commit into
Twixes wants to merge 1 commit into
Conversation
…GitHub Make the inbox report/PR detail actions clearer that they start an agent session, and require a personal GitHub integration before they can run. - Rename "Discuss" to "Discuss with agent" and the question placeholder to "Ask PostHog about this report…". - Disable Discuss / Create PR with a "connect GitHub to your account" disabledReason when the user has no personal GitHub integration, and show a "Connect personal GitHub for agent sessions" link to the left of Dismiss. - Add the missing "copy sharing link" button to the pull request detail. Generated-By: PostHog Code Task-Id: a030ae39-2898-4bef-8bc6-3cc67c1e45ef
|
React Doctor could not complete this scan.
Reviewed by React Doctor for commit |
Contributor
|
Reviews (1): Last reviewed commit: "feat(inbox): clarify agent-session actio..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the inbox, the "Discuss" / "Ask about this report…" copy doesn't make it clear that the button starts an agent session (people read it as leaving a note for other humans). On top of that, these actions author commits as the user, so they need a personal GitHub integration — but when one is missing the user only finds out via a toast after clicking. The pull request detail was also missing the "copy sharing link" button that the report detail has.
Changes
disabledReason("…you need to connect GitHub to your account for agent sessions"), and a "Connect personal GitHub for agent sessions" link button appears to the left of Dismiss (linking to GitHub settings). This replaces the need for the old "Connect a GitHub integration to start a discussion" message in the common case.How did you test this?
pnpm --filter @posthog/ui typecheck— passes.biome checkon the changed files — clean.pnpm --filter @posthog/ui test(inbox suite) — 697 passing.Automatic notifications
Created with PostHog Code from a Slack thread