test: Isolate local feature flag polling assertions - #868
Merged
Conversation
Contributor
|
Reviews (1): Last reviewed commit: "test: isolate local flag polling asserti..." | Re-trigger Greptile |
Contributor
posthog-python Compliance ReportDate: 2026-08-12 09:14:55 UTC ✅ All Tests Passed!111/111 tests passed Capture_V1 Tests✅ 94/94 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
arnohillen
approved these changes
Aug 13, 2026
arnohillen
left a comment
There was a problem hiding this comment.
[arno's agent] Reviewed at head 428fd8c: change verified against head code, CI classified, no blocking findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Several local feature flag evaluation tests patched the module-level
posthog.client.getfunction and asserted that it was never called. A background poller from another client could call the same mock while the test was running. This caused an intermittent CI failure even though the client under test evaluated its flag locally.The affected tests now patch
_load_feature_flagson their own client instance. The assertions still verify that local evaluation does not load flag definitions, but requests from unrelated clients can no longer change the call count.💚 How did you test it?
posthog/test/test_feature_flags.py: 173 passed with 13 subtests.📝 Checklist
If releasing new changes
sampo addto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Implemented with Pi under human direction after a flaky Python 3.13 CI failure on #867. Pi autoreview reported no actionable findings for commit
428fd8ca52ee0ccf48b361dfb3d85a823e0a7db4.