-
Notifications
You must be signed in to change notification settings - Fork 82
fix(mcp): restore analytics capture for standalone FastMCP 4 #936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
62bb16f
fix(mcp): capture standalone FastMCP on the v2 registry
lucasheriques 8865969
fix(mcp): preserve FastMCP schemas across setup order and versions
lucasheriques 7027977
fix(mcp): strip FastMCP analytics arguments from what was advertised
lucasheriques 2b91f14
chore(mcp): verify middleware dispatch without schema lookup
lucasheriques 43fa340
fix(mcp): resolve FastMCP argument ownership per request
lucasheriques File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| pypi/posthog: patch | ||
| --- | ||
|
|
||
| Fix missing MCP analytics events with standalone FastMCP 4 while preserving tool arguments and compatibility with MCP SDK v1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note
🤖 Automated comment by QA Swarm — not written by a human
[router] 🟡 MEDIUM
When
server.get_tool()fails, or returns an object whose.parametersis not a dict, this function returnsNone._wrap_v2_call_toolthen skips the strip step and sends the raw arguments to the real dispatch. The arguments still contain the injected analytics keys (context,conversation_id,llm_model).FastMCP binds tool arguments strictly. A direct call to
fastmcp.FastMCP.call_toolwith one unexpected keyword raises a pydanticValidationError(verified in a fastmcp 4.0.3 environment). So this fail-open path can break dispatch — the opposite of the invariant the otherexceptblocks in this PR protect.The common case looks safe: FastMCP's own
call_tool()resolves the tool throughself.get_tool(name, version=...)at the same point, so a lookup failure usually breaks the underlying dispatch too. The residual risk is narrower: a middleware whoseon_call_toolhook short-circuits before the manager stage and dispatches to a bound function directly. Dispatch then succeeds, but the PostHog lookup fails and the unstripped keys go through.None of the new tests in
test_fastmcp_v4.pybuild that shape, so the path is untested. This is plausible, not confirmed.Suggested action: either add a test for a tool that dispatches but does not resolve through
get_tool(), or confirm that the path is unreachable in the supported FastMCP middleware patterns and record that in the docstring.