fix: clean up async consumer waiters on cancellation - #940
Merged
marandaneto merged 1 commit intoSep 11, 2026
Merged
Conversation
marandaneto
approved these changes
Sep 11, 2026
Member
|
thanks @nickita-khylkouski |
marandaneto
force-pushed
the
fix/async-consumer-cancellation
branch
from
September 11, 2026 08:17
a3feb50 to
aeb4f45
Compare
marandaneto
enabled auto-merge (squash)
September 11, 2026 08:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Cancelling
_get_or_flushwhile it is insideasyncio.waitcan leave its queue and flush helper tasks pending. Put the wait intry/finally, cancel any unfinished helper tasks, and gather both before propagating cancellation.💚 How did you test it?
_get_or_flushand the worker pathThe repository-wide Ruff command currently reports existing formatting and legacy-lint findings in untouched files; the modified Python files pass formatting.
📝 Checklist
If releasing new changes
sampo addto generate a changeset fileAn equivalent patch changeset is included at
.sampo/changesets/async-consumer-cancellation.md.🤖 Agent context
Autonomy: Human-driven (agent-assisted)
The contributor directed the scope and exact cleanup behavior. Codex helped inspect the repository, apply the bounded change, and run the repository checks; the implementation cancels only unfinished waiter tasks and gathers both to avoid leaked-task warnings.