fix: preserve redirect URLs with async capture host prefixes - #941
Merged
marandaneto merged 1 commit intoSep 11, 2026
Merged
Conversation
Member
|
thanks @nickita-khylkouski |
marandaneto
approved these changes
Sep 11, 2026
marandaneto
force-pushed
the
fix/async-redirect-host-prefix
branch
from
September 11, 2026 08:17
c878d10 to
a5f94dc
Compare
marandaneto
enabled auto-merge (squash)
September 11, 2026 08:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
When the configured capture host contains a path prefix, passing relative redirect paths through an HTTPX client can reapply or retain that prefix incorrectly. Resolve each redirect against the current absolute URL, enforce the original origin, and pass absolute URLs through the redirect chain.
💚 How did you test it?
The repository-wide Ruff command currently reports existing formatting and legacy-lint findings in untouched files; the modified Python files pass formatting.
📝 Checklist
If releasing new changes
sampo addto generate a changeset fileAn equivalent patch changeset is included at
.sampo/changesets/async-capture-redirect-path-prefix.md.🤖 Agent context
Autonomy: Human-driven (agent-assisted)
The contributor directed the scope and redirect behavior. Codex helped inspect the repository, apply the bounded change, and run the repository checks; same-origin enforcement remains in place and fragments are not forwarded.