Fix incorrect claim about how GitHub builds squash commit messages - #84
Fix incorrect claim about how GitHub builds squash commit messages#84jnasbyupgrade wants to merge 1 commit into
Conversation
GitHub doesn't auto-build a squash commit message from a PR description; the maintainer manually copies the opening into it, which is what the hard-wrap rule actually depends on. ai/PR.md's own general no-hard-wrap rule has the same fix.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Claude finished @jnasbyupgrade's task in 1m 44s —— View job Reviewing PR #84
ReviewThis is a small, correct doc fix. The old text implied GitHub mechanically builds the squash commit message from the PR description in a way that depends on line-wrapping — that's not how it works. The new text correctly attributes it to the maintainer manually copying the opening in, which is the real reason hard-wrapped line breaks would leak into the resulting commit message.
No functional/build/test surface is touched (docs-only change to No changes requested — this looks good to merge. |
|
Closing — cat_tools#83 (the CLAUDE.md consolidation PR) hasn't actually merged yet, so this fix belongs there instead of as a follow-up on master. |
GitHub doesn't auto-build a squash commit message from a PR description — the maintainer manually copies the opening into it, which is what the hard-wrap rule actually depends on.
ai/PR.md's own general no-hard-wrap rule has the same fix.