Return default_version to stable now that 1.0.0 has shipped - #13
Merged
Conversation
1.0.0 is tagged and dist'd (RELEASE.md step 6, done outside this PR - make tag pushes to origin, which is a personal fork in this checkout, so the tag was created and pushed to upstream manually instead). This is step 7: flip default_version back to stable so ordinary source edits regenerate sql/count_nulls--stable.sql instead of silently corrupting the just-released sql/count_nulls--1.0.0.sql, add the update script from 1.0.0 to stable, and open a fresh stable section in HISTORY.md for the next cycle. Verified: make verify-results green, and the full update chain (CREATE EXTENSION VERSION '0.9.6' -> ALTER EXTENSION UPDATE -> stable) still works end to end. Also keeps sql/count_nulls--1.0.0.sql installable going forward (a manual DATA += in the Makefile) since it drops out of base.mk's install-script wildcard once it's no longer the "current version" file - the same gap already tracked as Postgres-Extensions/pgxntool#48.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jnasbyupgrade
marked this pull request as ready for review
July 24, 2026 23:01
jnasbyupgrade
added a commit
that referenced
this pull request
Jul 29, 2026
… fork The gate checked github.event.pull_request.head.repo.owner.login == 'jnasbyupgrade', written back when PRs came from that personal fork. Now that the convention is to push branches directly to this repo instead (never the fork), every PR's head repo owner is Postgres-Extensions, not jnasbyupgrade - so the condition never matched and claude-review silently skipped on every single PR this session (#12, #13, #14 all show it as skipped). Replaced with head.repo.full_name == github.repository, which is actually a tighter trust boundary than the old check: it only allows PRs whose head branch lives in this exact repo, requiring push access here, rather than naming one specific external fork as trusted.
jnasbyupgrade
added a commit
that referenced
this pull request
Jul 29, 2026
…RSION PR #13 (merged) flipped count_nulls.control's default_version to the stable pseudo-version, so a version-less CREATE EXTENSION now installs 'stable', not the last real release. The smoke test's version assertion still compared against PGXNVERSION (the PGXN distribution version, from META.in.json, still 1.0.0) - the exact distribution-vs-extension-version distinction RELEASE.md documents. Confirmed failing in CI (installed=stable expected=1.0.0) and locally (`make -s print-EXTENSION_count_nulls_VERSION` correctly reports stable). Fixed to assert against that variable instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reset version back to
stableafter release. Also adds a note to RELEASE.md's step 7 that this PR's own description should stay this small.