Skip to content

Point release tagging at the upstream remote explicitly, not origin - #18

Open
jnasbyupgrade wants to merge 1 commit into
update-pgxntool-2.2.0from
fix-pgxn-remote
Open

Point release tagging at the upstream remote explicitly, not origin#18
jnasbyupgrade wants to merge 1 commit into
update-pgxntool-2.2.0from
fix-pgxn-remote

Conversation

@jnasbyupgrade

Copy link
Copy Markdown
Contributor

origin in this checkout is the jnasbyupgrade fork, not the canonical Postgres-Extensions/pg_count_nulls repo, so make tag/make dist have always been one git remote -v slip away from tagging the wrong repo. pgxntool 2.2.0 (Postgres-Extensions/pgxntool#53) made the tagging targets' remote configurable via PGXN_REMOTE instead of hardcoding origin, so this sets PGXN_REMOTE = upstream in the Makefile and drops the RELEASE.md step that relied on the release-runner remembering to check origin by hand.

Stacked on #17 (the pgxntool 2.2.0 bump) since PGXN_REMOTE doesn't exist before that version — base.mk previously hardcoded origin with no override.

Verified with make -n tag PGXNVERSION=1.0.0: the push line now reads git push upstream 1.0.0 instead of git push origin 1.0.0.

origin in this checkout is the jnasbyupgrade fork, not the canonical Postgres-Extensions/pg_count_nulls repo, so make tag/make dist have always been one `git remote -v` slip away from tagging the wrong repo. pgxntool 2.2.0 (Postgres-Extensions/pgxntool#53) made the tagging targets' remote configurable via PGXN_REMOTE instead of hardcoding origin, so this sets PGXN_REMOTE = upstream here and drops the RELEASE.md step that relied on the release-runner remembering to check origin by hand.
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: b9515a39-9db4-4010-bd66-540fa44bf759

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant