ci: run full test-all suite instead of test - #50
Merged
jnasbyupgrade merged 1 commit intoJul 29, 2026
Conversation
make test only runs the standard suite; make test-all also runs the extra tests (test/extra/), giving CI full coverage.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jnasbyupgrade
marked this pull request as ready for review
July 29, 2026 18:19
jnasbyupgrade
added a commit
to jnasbyupgrade/pgxntool-test
that referenced
this pull request
Jul 29, 2026
…, base.mk fixes (Postgres-Extensions#31) Related pgxntool PR: Postgres-Extensions/pgxntool#61 New BATS coverage in `test/standard/`: - **`versioned-sql-race.bats`** (Postgres-Extensions#19): races two genuinely concurrent `make all` invocations against the same versioned-SQL target across 5 iterations, asserting the resulting file is never doubled. Verified by hand first that the *old* two-line recipe reproduces doubling (~1/3 of trials); the fixed single-redirect recipe never doubled across 15+ manual trials. - **`check-stale-expected.bats`** (Postgres-Extensions#14): orphaned-file failure (both the standalone target and via `make test` before PostgreSQL is needed), the pg_regress alternate-output-file (`_N.out`) false-positive exemption plus a case proving the exemption doesn't over-apply when the alternate's own base `.sql` is also missing, and the same coverage for the `test/build`/`test/build/expected` pair. - **`base-mk-fixes.bats`** (Postgres-Extensions#7, Postgres-Extensions#50, Postgres-Extensions#53): `EXTRA_CLEAN` targets the real `test/results/` directory and `make clean` actually removes it; `PGXN_REMOTE` defaults to `origin` and is overridable for both `tag` and `rmtag`; a throwaway Makefile that includes `pgxntool/base.mk` twice (directly and via an intermediate module) parses with no overriding-recipe warnings. **Postgres-Extensions#28 (variable rename) deliberately has no new test** — pure mechanical rename, no behavior change, already exercised by the existing suite's `DATA`/build-output coverage. Full suite passes 228/228, 0 skips. --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
jnasbyupgrade
added a commit
to jnasbyupgrade/pgxntool-test
that referenced
this pull request
Jul 29, 2026
…erywhere Add a "Compile the complete fixed-issues line" step to the /release skill, between reordering STABLE entries and stamping the version. Its purpose is for consumers of pgxntool: a single, complete, convenient list of every issue actually fixed in a release, independent of which changes were important enough to get their own narrated STABLE entry. Compiling that list requires unioning each merged PR's own `closingIssuesReferences` with a direct re-read of the PR body for `Fixes`/`Closes`/`Resolves` mentions -- and doing that surfaced a real, separate problem: GitHub only auto-closes the first issue in a single comma-separated line like `Fixes Postgres-Extensions#7, Postgres-Extensions#14, Postgres-Extensions#19`, silently dropping the rest with no error. 2.2.0 shipped with issues Postgres-Extensions#14, Postgres-Extensions#19, Postgres-Extensions#50, and Postgres-Extensions#53 all genuinely fixed by one PR whose body read `Fixes Postgres-Extensions#7, Postgres-Extensions#14, Postgres-Extensions#19, Postgres-Extensions#28, Postgres-Extensions#50, Postgres-Extensions#53` -- only Postgres-Extensions#7 auto-closed, and the other four sat open until a manual post-release audit caught it. The release skill's new step now also closes any such issue immediately rather than deferring it. Since that gotcha isn't specific to releases, document it everywhere a commit or PR might reference an issue: `commit-message-format.md` (commit messages) and `pr.md` (PR bodies) both now say to give each issue its own `Fixes #N` line, never a comma-separated list. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run-tests.ymlwas invokingmake test, which only runs the standard suite and skipstest/extra/(e.g. the pg_tle multi-version tests).make test-allso CI exercises the full suite.Test plan
make test-alllocally (worktree with submodule init + sibling pgxntool symlink) against thetletestcluster (pg_tle preloaded): 215/215 passed, 0 failed, 0 skipped.