Fix semantic highlighting cancellation during rapid typing#2301
Draft
Copilot wants to merge 3 commits into
Draft
Fix semantic highlighting cancellation during rapid typing#2301Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
6 tasks
Copilot
AI
changed the title
[WIP] Fix semantic highlighting breaks when rapidly typing
Prevent semantic token pipeline stalls from completion cancellation
Jun 10, 2026
Copilot
AI
changed the title
Prevent semantic token pipeline stalls from completion cancellation
Fix semantic highlighting cancellation during rapid typing
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rapid typing could cancel completion work in a way that left semantic token delta requests without a response, which prevented VS Code from updating semantic highlighting for newly typed text.
Request pipeline
PsesCompletionHandlerregistration so completion cancellations no longer block the semantic tokens pipeline.DidChangeTextDocumentsequencing.Cancellation handling
TaskCanceledExceptionin completion-item resolve and return the original item instead of letting cancellation escape through the LSP pipeline.Regression coverage
CancelAsync()to avoid synchronous cancellation analyzer violations.