Architecture: fold uuid/rar/eio/imap/ssh2 advertise into ext.json (#36204) - #37690
Merged
PurHur merged 1 commit intoSep 9, 2026
Merged
Conversation
…6204) Move five host|CV|env ExtensionPolicy advertisement rules into ext.json advertise so ExtensionRegistry::advertisesExtensionFor() is the SSOT; keep compliance helpers on the thin policy classes. No new C ABI. Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
deleted the
agent/issue-36204-fold-advertise-uuid-rar-eio-imap-ssh2
branch
September 9, 2026 20:27
This was referenced Sep 9, 2026
PurHur
added a commit
that referenced
this pull request
Sep 9, 2026
…nc (#36401) (#37696) Master tip verified locally (apply-patches pristine 27/27 incl. structgep, aot-smoke 9/9, north-star5-verify-fast OK). Sync bootstrap-inventory construct warnings after #37690 ExtensionPolicy fold so --check stays green. Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*ExtensionPolicy::advertisesExtension()rules intoext.jsonadvertise→ generatedExtensionRegistry::advertisesExtensionFor()(uuid host|CV; rar/eio/imap/ssh2 CV|env). Compliance helpers remain on thin policy classes.zend_module_entry/extension=opt-in.Test plan
./script/phpunit.sh --filter 'ExtensionPolicyAdvertiseTest|ExtensionPolicySubsetTest'→ 15/15 (33 assertions)./script/aot-smoke.sh→ 9/9 + size gate OKphp script/generate-extension-registry.php --check+sync-extension-manifests.php --check→ OKmake north-star5-verify-fast→ OK (Spine 8596/8596)Closes nothing alone — Part of #36204.
Made with Cursor