Perf: typed int **102 / pow(n,102) chained smul omit llvm.pow.f64 (#36386) - #37698
Closed
PurHur wants to merge 1 commit into
Closed
Perf: typed int **102 / pow(n,102) chained smul omit llvm.pow.f64 (#36386)#37698PurHur wants to merge 1 commit into
PurHur wants to merge 1 commit into
Conversation
…6386) Lower compile-time exponent 102 via (hundredfirst×n) chained smul.with.overflow in JitPowIntegerEmitHigh — omit llvm.pow.f64. Even: (-1)**102 === 1. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
north-star5-verify-fastgreen on tip before claim.pow(n, 102)via(hundredfirst×n)chainedsmul.with.overflowinJitPowIntegerEmitHigh— omitllvm.pow.f64. Even:(-1)**102 === 1.Zend/zend_operators.cpow_function/zend_pow/mul_function;ext/standard/math.cPHP_FUNCTION(pow).Part of #36386.
Test plan
./script/phpunit.sh --filter 'NoThrowPowHundredsecondMulAotTest|NoThrowPowHundredfirstMulAotTest|NoThrowPowHundredthMulAotTest'→ OK (12 tests, 69 assertions)./script/aot-smoke.sh→ 9/9php script/check-size-budgets.php→ OK (156)php script/opcode-corpus-md5.php --check→ OK (364 files)make north-star5-verify-fast→ OK (spine 8596/8596)script/differential-sweep.sh --aot --repeat 3→pow_hundredsecond_smul_36386.php3/3; remaining post-cutoff shard 49/49 ok (exit 0). First-pass log also showed 7 pre-existingDIFFnames unrelated to this change (same class as master noise; not introduced here).Made with Cursor