allow subtree KeyError to bubble - #892
Merged
Merged
Conversation
this behaviour was uncovered -- and I think the KeyError is actually
more readable than the custom exception:
```pytb
>>> Checker(ast.parse('a').body[0].value)
Traceback (most recent call last):
File "/home/asottile/workspace/pyflakes/pyflakes/checker.py", line 738, in __init__
scope_tp = Checker._ast_node_scope[type(tree)]
~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
KeyError: <class 'ast.Name'>
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "<python-input-5>", line 1, in <module>
Checker(ast.parse('a').body[0].value)
~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/asottile/workspace/pyflakes/pyflakes/checker.py", line 740, in __init__
raise RuntimeError('No scope implemented for the node %r' % tree)
RuntimeError: No scope implemented for the node Name(id='a', ctx=Load())
```
now:
```pytb
>>> Checker(ast.parse('a').body[0].value)
Traceback (most recent call last):
File "<python-input-2>", line 1, in <module>
Checker(ast.parse('a').body[0].value)
~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/asottile/workspace/pyflakes/pyflakes/checker.py", line 737, in __init__
scope_tp = Checker._ast_node_scope[type(tree)]
~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
KeyError: <class 'ast.Name'>
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this behaviour was uncovered -- and I think the KeyError is actually more readable than the custom exception:
>>> Checker(ast.parse('a').body[0].value) Traceback (most recent call last): File "/home/asottile/workspace/pyflakes/pyflakes/checker.py", line 738, in __init__ scope_tp = Checker._ast_node_scope[type(tree)] ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^ KeyError: <class 'ast.Name'> During handling of the above exception, another exception occurred: Traceback (most recent call last): File "<python-input-5>", line 1, in <module> Checker(ast.parse('a').body[0].value) ~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/asottile/workspace/pyflakes/pyflakes/checker.py", line 740, in __init__ raise RuntimeError('No scope implemented for the node %r' % tree) RuntimeError: No scope implemented for the node Name(id='a', ctx=Load())now:
>>> Checker(ast.parse('a').body[0].value) Traceback (most recent call last): File "<python-input-2>", line 1, in <module> Checker(ast.parse('a').body[0].value) ~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/asottile/workspace/pyflakes/pyflakes/checker.py", line 737, in __init__ scope_tp = Checker._ast_node_scope[type(tree)] ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^ KeyError: <class 'ast.Name'>