Skip to content

feat: Add the shared client theme object on message sent and in message object - #3209

Open
UnBonWhisky wants to merge 32 commits into
Pycord-Development:masterfrom
UnBonWhisky:master
Open

feat: Add the shared client theme object on message sent and in message object#3209
UnBonWhisky wants to merge 32 commits into
Pycord-Development:masterfrom
UnBonWhisky:master

Conversation

@UnBonWhisky

@UnBonWhisky UnBonWhisky commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

Summary

It adds the object of shared client theme described here by Discord.

Yes AI has been used (partially)

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.
  • AI Usage has been disclosed.
    • If AI has been used, I understand fully what the code does
  • I have read the Contributing Guidelines

@UnBonWhisky
UnBonWhisky requested review from a team and Lulalaby April 20, 2026 23:17
@UnBonWhisky
UnBonWhisky requested a review from plun1331 April 20, 2026 23:17
@github-project-automation github-project-automation Bot moved this to Todo in Pycord Apr 20, 2026
@UnBonWhisky
UnBonWhisky requested a review from a team as a code owner April 20, 2026 23:17
@pycord-app

pycord-app Bot commented Apr 20, 2026

Copy link
Copy Markdown

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/3209/head:pr-3209
git checkout pr-3209

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3209/head

@UnBonWhisky UnBonWhisky changed the title Add the shared client theme object on message sent and in message object feat: Add the shared client theme object on message sent and in message object Apr 20, 2026
@UnBonWhisky

Copy link
Copy Markdown
Contributor Author

Note : shared client theme should not work with components v2 (source: Discord docs) but it works.

{40C79FCB-7F68-49B9-BBA9-95913F88ABEE}

@Paillat-dev Paillat-dev self-assigned this Apr 22, 2026
@Paillat-dev
Paillat-dev self-requested a review April 22, 2026 13:53
Comment thread discord/enums.py Outdated
Comment thread discord/shared_client_theme.py Outdated
Comment thread discord/shared_client_theme.py Outdated
Comment thread discord/shared_client_theme.py Outdated
Comment thread discord/types/shared_client_theme.py Outdated
Comment thread docs/api/data_classes.rst Outdated

@plun1331 plun1331 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since shared client theme is constructible, I feel like we should add methods like set_colors and whatnot to make that easier

Comment thread discord/http.py Outdated
Comment thread CHANGELOG.md Outdated
Comment thread discord/shared_client_theme.py Outdated
Comment thread discord/shared_client_theme.py Outdated
Comment thread discord/shared_client_theme.py Outdated
Comment thread discord/shared_client_theme.py Outdated
Comment thread discord/abc.py Outdated
Comment thread discord/shared_client_theme.py Outdated
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Signed-off-by: Flavien F <65244389+UnBonWhisky@users.noreply.github.com>

@Paillat-dev Paillat-dev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good enough to me, thanks for the PR ! Just a couple nitpicks.

Comment thread discord/shared_client_theme.py Outdated
Comment thread CHANGELOG.md Outdated
UnBonWhisky and others added 2 commits June 9, 2026 12:49
Co-authored-by: Paillat <jeremiecotti@ik.me>
Signed-off-by: UnBonWhisky <65244389+UnBonWhisky@users.noreply.github.com>
@Lulalaby
Lulalaby requested a review from a team as a code owner July 30, 2026 13:25
@github-actions github-actions Bot added the invalid This doesn't seem right label Jul 30, 2026
@github-actions

This comment was marked as resolved.

@github-actions github-actions Bot closed this Jul 30, 2026
@github-actions github-actions Bot locked as spam and limited conversation to collaborators Jul 30, 2026
@github-project-automation github-project-automation Bot moved this from Todo to Done in Pycord Jul 30, 2026
@Paillat-dev Paillat-dev reopened this Jul 30, 2026
@Paillat-dev Paillat-dev removed the invalid This doesn't seem right label Jul 30, 2026
@Pycord-Development Pycord-Development unlocked this conversation Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants