Fix UnbalancedSinkhornTransport transform failing on nx.array_equal (closes #650) - #837
Open
JaySingh79 wants to merge 3 commits into
Open
Fix UnbalancedSinkhornTransport transform failing on nx.array_equal (closes #650)#837JaySingh79 wants to merge 3 commits into
JaySingh79 wants to merge 3 commits into
Conversation
…loses PythonOT#650) fit() now initializes the backend attribute nx before the check_params gate, matching the behavior of BaseTransport.fit. Previously, a fit call with missing parameters left self.nx as None, causing any subsequent transform() call to crash with: AttributeError: 'NoneType' object has no attribute 'array_equal' Adds a non-regression test covering both incomplete fit and a separate transform call.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #837 +/- ##
=======================================
Coverage 96.86% 96.86%
=======================================
Files 128 128
Lines 25709 25724 +15
=======================================
+ Hits 24902 24917 +15
Misses 807 807 🚀 New features to boost your workflow:
|
Collaborator
|
Hello @JaySingh79 thanks for the PR, this is a nice fix, could you please add the information in the RELEASE.md file in the Bug fix section (with referencexs to the Issue and PR) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fit() now initializes the backend attribute nx before the check_params
gate, matching the behavior of BaseTransport.fit. Previously, a fit call
with missing parameters left self.nx as None, causing any subsequent
transform() call to crash with:
AttributeError: 'NoneType' object has no attribute 'array_equal'
Adds a non-regression test covering both incomplete fit and a separate
transform call.
Types of changes
Motivation and context / Related issue
How has this been tested (if it applies)
PR checklist