feat(sdk): align request errors, retry delays and client cloning - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align TypeScript request-error classification, retry-delay boundaries, and client cloning with the pinned Anthropic sdk-v0.127.0 baseline.
APIError, preserving existing constructors and causes. HTTP status/header metadata remains absent on non-HTTP errors.withOptions()to derive a client of the same concrete type, preserving unspecified settings, credentials, custom fetch, middleware, and the resolved base URL. Supplied client-level headers, query defaults, and middleware replace the corresponding option.Why
Allow a single
APIErrorcatch to cover request failures, prevent oversized delays from becoming immediate retries, and make configuration reuse consistent across clients.Verification
npm run build: CommonJS and ESM build passed.npm run typecheck: passed, including derived-client and error-subclass types.npm test: 3,375 passed.npm run docs:check: passed; 26 README TypeScript snippets compiled.maxRetries: 0; controlled transport tests exercise retry timing, error classification, and derived-client configuration.Impact
Unreleased.Breaking change:
instanceof APIErrornow includes connection, timeout, and cancellation errors. Guard optionalstatusandheaders, and handleAPIUserAbortErrorfirst when cancellation needs separate treatment. Existing HTTP-specific subclasses retain their typed metadata.