PLAN: rule 6's enumeration omitted the canary and carried drifted zh-cn lines - #68
Merged
Conversation
…cn lines Rule 6 is the section a repointer consults for "the enumerated reads, the acceptance check, and why CI does not cover it". Its tables were the last place in this document still saying 21 reads across three repos. #64 corrected the P3 checklist line to 28 across four repos but not this section, so the corrected total and the stale enumeration sat in the same file. Anyone following the pointer got a missing consumer. - 21/three -> 28/four throughout, with test-actions-lecture-intro's seven reads enumerated (heavy_tails 822/849/850/874 and data.ipynb:37 on media, mle:93 and inequality:249 on the redirect form) - lecture-intro.zh-cn's heavy_tails lines corrected 810/837/838/862 -> 811/838/839/863, the +1 drift from its 2026-08-10 sync PRs, and the whole table date-stamped with a re-derive instruction rather than presented as fact - the acceptance grep gains the canary path, which lives under the other clone root and so was invisible to a repos/-shaped command; plus a second grep for `high_dim_data`, since the media-host grep passes trivially on a tree nobody repointed - the audit-coverage paragraph recounted: the strict audit sees 12 of 28, the two data-url-guards recover 2 more, and 14 reads across zh-cn and the canary have no automated check of any kind Both superseded figures are now recorded in the section as superseded, since each has been mistaken for the total once. Measured against each repo's main on 2026-08-11. Plan: QuantEcon/workspace-lectures#23 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates PLAN.md’s “repoint rule 6” documentation so the enumerated high_dim_data consumer reads, line-number snapshots, and fold acceptance checks reflect the current 28-read / 4-repo reality (including the test-actions-lecture-intro canary) and recent lecture-intro.zh-cn drift.
Changes:
- Corrects and expands the consumer-read counts/tables (21→28; 3 repos→4 repos) and adds a “seen by” coverage column.
- Updates zh-cn line-number snapshots and adds a date stamp + re-derive guidance.
- Extends the fold acceptance check to include the canary path and adds a second “legacy reference” grep.
Suppressed comments (1)
PLAN.md:196
- The acceptance check
grep -rn 'high_dim_data' ...is very broad and can fail on unrelated mentions (e.g., prose, comments) even after URLs have been repointed. To make the check reliably indicate “no remaining legacy URLs,” grep for the repo-qualified substring instead (e.g.,QuantEcon/high_dim_data).
A second grep is what actually proves the fold, since the one above passes trivially on a tree that was never repointed at all:
grep -rn 'high_dim_data' <the same four lecture trees>
That must also return nothing.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Copilot read the bare `high_dim_data` needle as an imprecision that would false-positive on prose, and suggested narrowing both greps to `QuantEcon/high_dim_data`. The needle is deliberate, but nothing said so, which is a fair documentation gap. Records the reasoning rather than the conclusion: an acceptance gate's error costs are asymmetric (a false positive costs five seconds, a false negative ships a broken fold); the broad form also catches a fork reference and a URL that lost its org prefix; and inside a lecture tree a non-URL hit is a finding to sweep, not noise -- which is the opposite of the org-wide gate, worded as zero *executable data reads* precisely because prose mentions there are permanent. Measured while checking: all 28 hits across the four lecture trees are org-qualified URL reads, so the two forms are equivalent today. The broad one differs only on cases you want to hear about. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rule 6 is the section a repointer consults for "the enumerated reads, the acceptance check, and why CI does not cover it" — PLAN.md's P3 checklist points there explicitly. Its tables were the last place in this document still saying 21 reads across three repos.
#64 corrected the P3 checklist line to 28 across four repos but not this section, so the corrected total and the stale enumeration have been sitting in the same file since 2026-08-10. Anyone doing PR set C by following the pointer got a missing consumer and four wrong line numbers.
What changed
The counts. 21/three → 28/four throughout, with
test-actions-lecture-intro's seven reads enumerated for the first time:heavy_tails.md:822, 849, 850, 874and_static/lecture_specific/inequality/data.ipynb:37on the media host,mle.md:93andinequality.md:249on thegithub.com/*/raw/redirect form. The by-repo table gains a "seen by" column, which is where the interesting fact lives — two of the four consumers are seen by nothing.The zh-cn line numbers.
heavy_tails.md810/837/838/862 → 811/838/839/863, the +1 drift from the six sync PRs that merged on 2026-08-10.mle.md:105andinequality.md:256are unchanged. Re-derived againstmainthis morning withbin/zh-fold-lines, and the whole table is now date-stamped and carries a re-derive instruction rather than being presented as fact — that drift happened in a single afternoon, from a sync PR that never touched a data-read line.The acceptance check. It gains the canary path. The old command was shaped around
repos/, and the canary is cloned underrepos-infrastructure/in the workspace, so no amount of care with the old command would have found it. A second grep is added forhigh_dim_dataitself, because the media-host grep passes trivially on a tree that was never repointed at all — it only proves the absence of one wrong spelling, not the presence of the right one.The coverage paragraph. Recounted from "9 of 21": the strict audit sees 12 of 28 (the
.mdreads in intro and wasm), the twodata-url-guardworkflows recover 2 more by grepping all oflectures/including_staticnotebooks, and 14 reads acrosslecture-intro.zh-cnandtest-actions-lecture-introhave no automated check of any kind.Why the superseded figures are kept
Both are now recorded in the section as superseded, with a line saying the table is what was measured. Each has been mistaken for the total once already — "12 media reads" is the intro + wasm subset, and "21 reads / three repos" omits the canary. Deleting them silently is how the same mistake gets made a third time.
No behaviour change; docs only. Plan: QuantEcon/workspace-lectures#23
🤖 Generated with Claude Code