Skip to content

PLAN: rule 6's enumeration omitted the canary and carried drifted zh-cn lines - #68

Merged
mmcky merged 2 commits into
mainfrom
plan/rule6-enumeration-canary
Aug 11, 2026
Merged

PLAN: rule 6's enumeration omitted the canary and carried drifted zh-cn lines#68
mmcky merged 2 commits into
mainfrom
plan/rule6-enumeration-canary

Conversation

@mmcky

@mmcky mmcky commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Rule 6 is the section a repointer consults for "the enumerated reads, the acceptance check, and why CI does not cover it" — PLAN.md's P3 checklist points there explicitly. Its tables were the last place in this document still saying 21 reads across three repos.

#64 corrected the P3 checklist line to 28 across four repos but not this section, so the corrected total and the stale enumeration have been sitting in the same file since 2026-08-10. Anyone doing PR set C by following the pointer got a missing consumer and four wrong line numbers.

What changed

The counts. 21/three → 28/four throughout, with test-actions-lecture-intro's seven reads enumerated for the first time: heavy_tails.md:822, 849, 850, 874 and _static/lecture_specific/inequality/data.ipynb:37 on the media host, mle.md:93 and inequality.md:249 on the github.com/*/raw/ redirect form. The by-repo table gains a "seen by" column, which is where the interesting fact lives — two of the four consumers are seen by nothing.

The zh-cn line numbers. heavy_tails.md 810/837/838/862 → 811/838/839/863, the +1 drift from the six sync PRs that merged on 2026-08-10. mle.md:105 and inequality.md:256 are unchanged. Re-derived against main this morning with bin/zh-fold-lines, and the whole table is now date-stamped and carries a re-derive instruction rather than being presented as fact — that drift happened in a single afternoon, from a sync PR that never touched a data-read line.

The acceptance check. It gains the canary path. The old command was shaped around repos/, and the canary is cloned under repos-infrastructure/ in the workspace, so no amount of care with the old command would have found it. A second grep is added for high_dim_data itself, because the media-host grep passes trivially on a tree that was never repointed at all — it only proves the absence of one wrong spelling, not the presence of the right one.

The coverage paragraph. Recounted from "9 of 21": the strict audit sees 12 of 28 (the .md reads in intro and wasm), the two data-url-guard workflows recover 2 more by grepping all of lectures/ including _static notebooks, and 14 reads across lecture-intro.zh-cn and test-actions-lecture-intro have no automated check of any kind.

Why the superseded figures are kept

Both are now recorded in the section as superseded, with a line saying the table is what was measured. Each has been mistaken for the total once already — "12 media reads" is the intro + wasm subset, and "21 reads / three repos" omits the canary. Deleting them silently is how the same mistake gets made a third time.

No behaviour change; docs only. Plan: QuantEcon/workspace-lectures#23

🤖 Generated with Claude Code

…cn lines

Rule 6 is the section a repointer consults for "the enumerated reads, the
acceptance check, and why CI does not cover it". Its tables were the last
place in this document still saying 21 reads across three repos.

#64 corrected the P3 checklist line to 28 across four
repos but not this section, so the corrected total and the stale enumeration
sat in the same file. Anyone following the pointer got a missing consumer.

- 21/three -> 28/four throughout, with test-actions-lecture-intro's seven
  reads enumerated (heavy_tails 822/849/850/874 and data.ipynb:37 on media,
  mle:93 and inequality:249 on the redirect form)
- lecture-intro.zh-cn's heavy_tails lines corrected 810/837/838/862 ->
  811/838/839/863, the +1 drift from its 2026-08-10 sync PRs, and the whole
  table date-stamped with a re-derive instruction rather than presented as
  fact
- the acceptance grep gains the canary path, which lives under the other
  clone root and so was invisible to a repos/-shaped command; plus a second
  grep for `high_dim_data`, since the media-host grep passes trivially on a
  tree nobody repointed
- the audit-coverage paragraph recounted: the strict audit sees 12 of 28,
  the two data-url-guards recover 2 more, and 14 reads across zh-cn and the
  canary have no automated check of any kind

Both superseded figures are now recorded in the section as superseded, since
each has been mistaken for the total once.

Measured against each repo's main on 2026-08-11.

Plan: QuantEcon/workspace-lectures#23

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings August 11, 2026 02:32

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates PLAN.md’s “repoint rule 6” documentation so the enumerated high_dim_data consumer reads, line-number snapshots, and fold acceptance checks reflect the current 28-read / 4-repo reality (including the test-actions-lecture-intro canary) and recent lecture-intro.zh-cn drift.

Changes:

  • Corrects and expands the consumer-read counts/tables (21→28; 3 repos→4 repos) and adds a “seen by” coverage column.
  • Updates zh-cn line-number snapshots and adds a date stamp + re-derive guidance.
  • Extends the fold acceptance check to include the canary path and adds a second “legacy reference” grep.
Suppressed comments (1)

PLAN.md:196

  • The acceptance check grep -rn 'high_dim_data' ... is very broad and can fail on unrelated mentions (e.g., prose, comments) even after URLs have been repointed. To make the check reliably indicate “no remaining legacy URLs,” grep for the repo-qualified substring instead (e.g., QuantEcon/high_dim_data).
A second grep is what actually proves the fold, since the one above passes trivially on a tree that was never repointed at all:

    grep -rn 'high_dim_data' <the same four lecture trees>

That must also return nothing.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread PLAN.md Outdated
Copilot read the bare `high_dim_data` needle as an imprecision that
would false-positive on prose, and suggested narrowing both greps to
`QuantEcon/high_dim_data`. The needle is deliberate, but nothing said
so, which is a fair documentation gap.

Records the reasoning rather than the conclusion: an acceptance gate's
error costs are asymmetric (a false positive costs five seconds, a
false negative ships a broken fold); the broad form also catches a fork
reference and a URL that lost its org prefix; and inside a lecture tree
a non-URL hit is a finding to sweep, not noise -- which is the opposite
of the org-wide gate, worded as zero *executable data reads* precisely
because prose mentions there are permanent.

Measured while checking: all 28 hits across the four lecture trees are
org-qualified URL reads, so the two forms are equivalent today. The
broad one differs only on cases you want to hear about.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@mmcky
mmcky merged commit ea2dfdc into main Aug 11, 2026
1 check passed
@mmcky
mmcky deleted the plan/rule6-enumeration-canary branch August 11, 2026 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants