-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Generalize metrics and add nullability delta metric #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Moritz Potthoff (MoritzPotthoffQC)
wants to merge
15
commits into
main
Choose a base branch
from
generalize-metrics-add-nullability
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
e97b755
init
MoritzPotthoffQC 1e72823
better output
MoritzPotthoffQC 1d7bdeb
cleanup
MoritzPotthoffQC a74429f
refactor
MoritzPotthoffQC 71338c9
Potential fix for pull request finding
MoritzPotthoffQC cd33f6a
fix
MoritzPotthoffQC f66bfa0
fix
MoritzPotthoffQC db3b168
Potential fix for pull request finding
MoritzPotthoffQC eb1c427
Merge branch 'main' into generalize-metrics-add-nullability
MoritzPotthoffQC 2923f2e
Update docs/api/metrics.rst
MoritzPotthoffQC e1ea6bd
Update tests/summary/fixtures/metrics_null_fraction/test_metrics_null…
MoritzPotthoffQC fc0426a
chore: Update pixi lockfile (#42)
quant-ranger[bot] f5b9117
review
MoritzPotthoffQC e374f0d
fix
MoritzPotthoffQC 627721e
fix
MoritzPotthoffQC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(moving this here to get a thread)
I see, good point!
Right now, I am really only interested in the variant implemented here right now.
As I see it, we currently follow two objectives:
I think (1) makes sense for numeric columns and in the context of diffly. (2) is also nice since it allows us to understand how the overall data changed (and it generalizes to non-numeric columns).
I could imagine that it would even be nice to expand on (2) in the future (e.g., by providing more metrics in this way). If we do that, we should probably make the differentiation obvious (e.g., through different modules). Wdyt, EgeKaraismailogluQC ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My impression is that we should probably even do this now already