Implement account menu design#564
Merged
Merged
Conversation
dewabisma
reviewed
Jul 14, 2026
| title: l10n.addAccountMenuImportKeystoneTitle, | ||
| subtitle: l10n.addAccountMenuImportKeystoneSubtitle, | ||
| onTap: _onImportKeystone, | ||
| colors: colors, |
Collaborator
There was a problem hiding this comment.
Since this widget is a proper widget instead of a var or just method. I think we can get the colors and text inside the widget definition instead of passing as parameters. This way we don't repeat unnecessarily.
dewabisma
reviewed
Jul 14, 2026
| icon: Icons.radar_outlined, | ||
| title: l10n.addAccountMenuDiscoverMultisigTitle, | ||
| subtitle: l10n.addAccountMenuDiscoverMultisigSubtitle, | ||
| colors: colors, |
Collaborator
There was a problem hiding this comment.
Same issue here with repeating colors and text theme.
dewabisma
reviewed
Jul 14, 2026
| child: Row( | ||
| mainAxisAlignment: MainAxisAlignment.spaceBetween, | ||
| children: [ | ||
| Text(title, style: text.paragraph?.copyWith(fontSize: 18, color: colors.textPrimary)), |
Collaborator
There was a problem hiding this comment.
AI really like to do unnecessary override like colors.textPrimary.
We don't need to, text primary is the default color.
Collaborator
Author
There was a problem hiding this comment.
theyre not uneccessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement account menu designs
