Skip to content

Introduce skid_steer as a new way to load assets - #515

Merged
patowen merged 6 commits into
Ralith:masterfrom
patowen:introduce-skid-steer
Aug 30, 2026
Merged

Introduce skid_steer as a new way to load assets#515
patowen merged 6 commits into
Ralith:masterfrom
patowen:introduce-skid-steer

Conversation

@patowen

@patowen patowen commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

This is a relatively significant refactor of Hypermine, switching up asset loading to use a new library called "skid_steer".

It introduces the following changes:

  • A custom AssetLoader type is added to drive asset loading, acting as the glue between skid_steer and Hypermine. This completely replaces the old loader module.
  • All uses of the staging buffer and transfer module from the temporary lahar_deprecated module have been replaced with a vendored growable_ring implementation from @Ralith, and a ParallelQueue from the current version of lahar. This allows us to finally remove the lahar_deprecated module, a task that I had hoped to do years ago.
  • PNG loading and GLTF loading, the only two processes that depended on the old Loader, have been migrated to the new AssetLoader.
  • File-processing (reading PNGs and GLBs) and Vulkan-wrangling (making Vulkan calls) have been fully separated, with all data being read into memory in a convenient form before being passed into Vulkan data structures.
  • To support some of the above changes, some data has been moved around, including the addition of a new ShaderData struct to pass around global data used for rendering.

@patowen
patowen force-pushed the introduce-skid-steer branch 3 times, most recently from 614549c to 656444b Compare August 22, 2026 02:41
Comment thread client/src/graphics/gltf_mesh.rs
Comment thread client/src/graphics/gltf_mesh.rs Outdated
@patowen
patowen requested a review from Ralith August 22, 2026 03:06
@patowen
patowen force-pushed the introduce-skid-steer branch 2 times, most recently from 2ac99ab to 359c1aa Compare August 25, 2026 02:21
@patowen
patowen marked this pull request as ready for review August 26, 2026 02:39

@Ralith Ralith left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review is just getting started, but it may be a few days before I make more progress.

Comment thread client/src/graphics/asset_loader.rs
Comment thread client/src/graphics/asset_loader.rs
Comment thread client/src/graphics/asset_loader.rs Outdated
Comment thread client/src/graphics/asset_loader.rs Outdated
Comment thread client/src/graphics/asset_loader.rs Outdated
Comment thread client/src/graphics/asset_loader.rs Outdated
Comment thread client/src/graphics/asset_loader.rs Outdated
Comment thread client/src/graphics/asset_loader.rs Outdated
Comment thread client/src/graphics/asset_loader.rs
Comment thread client/src/graphics/asset_loader.rs Outdated
@patowen
patowen force-pushed the introduce-skid-steer branch from 359c1aa to cd2bff8 Compare August 28, 2026 04:22
@patowen
patowen requested a review from Ralith August 29, 2026 15:55
patowen added a commit to patowen/hypermine that referenced this pull request Aug 29, 2026
Comment thread client/src/graphics/asset_loader.rs Outdated
Comment thread client/src/graphics/mod.rs Outdated
Comment thread client/src/graphics/asset_loader.rs Outdated
Comment thread client/src/graphics/gltf_mesh.rs Outdated
@patowen
patowen force-pushed the introduce-skid-steer branch from cd2bff8 to 7fdec92 Compare August 29, 2026 23:28
@patowen

patowen commented Aug 29, 2026

Copy link
Copy Markdown
Collaborator Author

I'll request one more quick review to double-check my latest changes, although based on your previous approval, I'm pretty confident this is safe to merge as-is.

@patowen
patowen requested a review from Ralith August 29, 2026 23:30
@patowen
patowen force-pushed the introduce-skid-steer branch from 7fdec92 to 7be06ff Compare August 29, 2026 23:55
@patowen
patowen merged commit 29ef711 into Ralith:master Aug 30, 2026
4 checks passed
@patowen
patowen deleted the introduce-skid-steer branch August 30, 2026 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants