Conversation
Signed-off-by: hazre <mail@haz.re>
hazre
force-pushed
the
hazre/refactor/update-linux-bootstrap
branch
from
August 10, 2026 15:21
568b589 to
4efce25
Compare
|
Download the artifacts for this pull request: |
hazre
changed the title
art0007i
requested changes
Sep 15, 2026
art0007i
left a comment
art0007i
left a comment
There was a problem hiding this comment.
lol most of the changes in this pr are reverting things that don't need to be reverted. at this point I would only keep the comment on line 6
|
|
||
| # ~ Launch Resonite! :) ~ | ||
|
|
||
| exec "$DOTNET_EXECUTABLE" "$ENTRY_POINT" "$@" |
There was a problem hiding this comment.
don't revert this, it was a change we made intentionally because it's better, see #23 (comment)
this means you should delete the dotnet function you also added back.
| # Also make sure that the alternate Renderite script is executable as well | ||
| # so that Resonite can run it. | ||
|
|
||
| chmod +x "$RENDERER_SCRIPT" |
There was a problem hiding this comment.
why remove this? did it cause issues? if not I think we should keep it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.