Conversation
Signed-off-by: hazre <mail@haz.re>
Signed-off-by: hazre <mail@haz.re>
Signed-off-by: hazre <mail@haz.re>
Signed-off-by: hazre <mail@haz.re>
|
Download the artifacts for this pull request: |
art0007i
requested changes
Sep 14, 2026
art0007i
left a comment
There was a problem hiding this comment.
Nice fix, that's kinda weird that System.Net.Quic loads outside of our ALC... does it get loaded even before bepisloader? I would think not, so maybe we could be able to load it inside the ALC? or does dotnet have some weird hardcoded behavior around their own system dlls?
Member
Author
|
I'm pretty sure default ALC is the entrypoint, which in our case is BepisLoader.dll. But I rather avoid a hardcoded fix. that's more or less same thing as Hardware.info fix we had back in the day. This fix is dynamic, so it will work with any future reso version regardless of what they add or remove. |
Signed-off-by: hazre <mail@haz.re>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the issue of QUIC not working on linux. I also made the bepisloader logger a bit nicer and for it to always to log regardless of debug or not, so future bug reports are easier.
quic stuff is part of
System.Net.Quicmeaning it loads as part of standard .NET "default" ALC (AssemblyDependencyResolver).usually that just works since its shipped with dotnet itself but I guess quic requires some system libs for it to work (on linux).
basically #32 only so far has handled native libs that directly get loaded by resonite itself (managed ALC) as part of
AppDomain.CurrentDomain.AssemblyResolvefallback, so we never overrode/handled the default ALC.The fix is rather simple but I'm very surprised that this hasn't exploded in our faces a lot sooner.