fix: skip unresolvable assemblies during plugin discovery scan

[hazre]

This fixes the good old System.IO.Ports error from way back, which was nothing but a false positive because the walker, well walked too much.

for example:

[Debug  :   BepInEx] Examining 'C:\Users\haz\AppData\Roaming\com.kesomannen.gale\resonite\profiles\Default\BepInEx\plugins\Nytra-InterprocessLib\InterprocessLib.BepisLoader\InterprocessLib.FrooxEngine.dll'
[Error  :   BepInEx] Mono.Cecil.AssemblyResolutionException: Failed to resolve assembly: 'System.IO.Ports, Version=0.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'
   at Mono.Cecil.BaseAssemblyResolver.Resolve(AssemblyNameReference name, ReaderParameters parameters)
   at Mono.Cecil.BaseAssemblyResolver.Resolve(AssemblyNameReference name)
   at Mono.Cecil.DefaultAssemblyResolver.Resolve(AssemblyNameReference name)
   at BepInEx.Bootstrap.BaseChainloader`1.ReferencesThisAssembly(AssemblyDefinition ass, HashSet`1 seen) in C:\Users\haz\dev\BepInEx\BepInEx.Core\Bootstrap\BaseChainloader.cs:line 104
   at BepInEx.Bootstrap.BaseChainloader`1.ReferencesThisAssembly(AssemblyDefinition ass, HashSet`1 seen) in C:\Users\haz\dev\BepInEx\BepInEx.Core\Bootstrap\BaseChainloader.cs:line 105
   at BepInEx.Bootstrap.BaseChainloader`1.ReferencesThisAssembly(AssemblyDefinition ass, HashSet`1 seen) in C:\Users\haz\dev\BepInEx\BepInEx.Core\Bootstrap\BaseChainloader.cs:line 105
   at BepInEx.Bootstrap.BaseChainloader`1.ReferencesThisAssembly(AssemblyDefinition ass, HashSet`1 seen) in C:\Users\haz\dev\BepInEx\BepInEx.Core\Bootstrap\BaseChainloader.cs:line 105
   at BepInEx.Bootstrap.BaseChainloader`1.HasBepinPlugins(AssemblyDefinition ass) in C:\Users\haz\dev\BepInEx\BepInEx.Core\Bootstrap\BaseChainloader.cs:line 112
   at BepInEx.Bootstrap.TypeLoader.FindPluginTypes[T](String directory, Func`3 typeSelector, Func`2 assemblyFilter, String cacheName) in C:\Users\haz\dev\BepInEx\BepInEx.Core\Bootstrap\TypeLoader.cs:line 158

[github-actions]

Download the artifacts for this pull request:

• BepInEx_CI.zip

[art0007i]

should still print a basic debug log ? like failed to load assembly System.IO.Ports

[hazre]

The thing is it's not supposed to load it in the first place. it's a transitive dependency that's not even used by Resonite or Bepis. it's something for legacy stuff. the problem is Cecil Resolve goes way down the dependency graph, where it has nothing to do there. I don't mind logging something but it's not "failing"

[art0007i]

ok, then the message does not need to mention failing at all. I think it's good to log it still, just make it debug log level

[hazre]

is this good?

[art0007i]

yep it's good!