Use notFalsy and notNullType in the docs examples - #1860
Merged
Merged
Conversation
alganet
approved these changes
Sep 21, 2026
Member
|
Thanks for your contribution! 🐼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every example of the
notprefix in the docs calls a rule that v3 hasn't got.v::notEmpty()->assert('hello')throwsComponentException: "notEmpty" is not a valid rule name, andv::notNull()does the same, so copying either off the page gets you an exception insted of the message it promises. Of the nine prefix sections on that page its the only one that doesn't run at all.The migration guide already settles it: "NotEmpty renamed to Falsy", with
v::notFalsy()as the prefixed shortcut. The generated mixins agree.src/Mixins/NotBuilder.phpdeclaresnotFalsy()andnotNullType(), and neither of the old names turns up anywhere insrc/, so thats the pair I've gone with. The claimed output changes with it,v::notFalsy()->assert('')prints"" must not be falsy.That same
v::notEmpty()call is the placeholder pipes example indocs/feature-guide.mdanddocs/messages/placeholder-pipes.md, so those throw too. Their claimed output I've left alone,templated()overrides the rule's own message soThe email field is requiredstill prints.