Skip to content

[codex] Allow bookmarks without shortcuts - #3

Merged
mdroidian merged 1 commit into
mainfrom
codex/optional-bookmark-shortcuts
Jun 30, 2026
Merged

[codex] Allow bookmarks without shortcuts#3
mdroidian merged 1 commit into
mainfrom
codex/optional-bookmark-shortcuts

Conversation

@mdroidian

@mdroidian mdroidian commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • allow saved pages to omit a keyboard shortcut
  • keep shortcut badges and keyboard matching guarded for shortcutless entries
  • reject invalid non-empty shortcut values instead of silently treating them as blank

Validation

  • npx prettier --check src/components/QuickSwitcherSettings.tsx src/quickSwitcher.tsx tests/quickSwitcher.test.ts
  • npm test
  • npm run build:roam
  • subagent review: initial edge case found and fixed; second review found no issues

Open in Devin Review

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Free

Run ID: 641816cb-aed3-4920-ae0d-318b5ca49fb5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands.

@mdroidian
mdroidian merged commit 44e7f41 into main Jun 30, 2026
2 checks passed
@mdroidian
mdroidian deleted the codex/optional-bookmark-shortcuts branch June 30, 2026 22:38

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@charliecreates charliecreates Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the latest changes, and I don't have actionable feedback to address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant