Skip to content

[codex] Support saved block entries - #8

Merged
mdroidian merged 1 commit into
mainfrom
codex/block-bookmarks
Jun 30, 2026
Merged

[codex] Support saved block entries#8
mdroidian merged 1 commit into
mainfrom
codex/block-bookmarks

Conversation

@mdroidian

@mdroidian mdroidian commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add saved block entries alongside saved pages
  • open block entries with Roam mainWindow.openBlock and label page/block entries in the switcher
  • preserve old saved page entries while storing new target metadata for pages and blocks
  • update settings and README copy from page-only bookmarks to saved entries

Validation

  • npx prettier --check README.md src/quickSwitcher.tsx src/components/QuickSwitcherSettings.tsx src/components/QuickSwitcherDialog.tsx src/index.ts src/utils/quickSwitcher.ts src/types/quickSwitcher.ts tests/quickSwitcher.test.ts
  • npm test
  • npm run build:roam
  • subagent review: no correctness findings; residual runtime coverage gaps noted for addBlock/getBlockByUid and mixed duplicate/shortcut flows

Open in Devin Review

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Free

Run ID: 05909930-7a9f-4ac3-871b-309540adf221

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands.

@mdroidian
mdroidian merged commit e6a82e9 into main Jun 30, 2026
2 checks passed
@mdroidian
mdroidian deleted the codex/block-bookmarks branch June 30, 2026 23:27

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

Comment thread src/index.ts
Comment on lines +34 to +35
id: "bookmarked-entries",
name: "Saved Entries",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Settings panel ID renamed from 'bookmarked-pages' to 'bookmarked-entries'

The settings panel section ID changed from bookmarked-pages to bookmarked-entries (src/index.ts:34). This is safe if extensionAPI.settings.panel.create replaces the entire panel on load (typical behavior). However, if the Roam extension framework tracks individual settings items by ID across loads, the old bookmarked-pages entry could remain orphaned in stored settings. Worth confirming this does not cause duplicate settings panel sections for users upgrading from the previous version.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@charliecreates charliecreates Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking feedback (1)
  1. Add targeted tests for the new block-entry lifecycle — tests/quickSwitcher.test.ts
    The utility suite now covers parsing and block title derivation, but it still doesn’t exercise the highest-risk mixed flows introduced in this PR (addBlock + target-based dedupe + open behavior).
    Consider adding focused coverage for: rejecting page UIDs in addBlock, ensuring block targets route through openBlock, and mixed page/block duplicate+shortcut scenarios after sanitization.

If you want me to push fixes, reply with item numbers (for example: please fix 1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant