[Feat] Separate model credentials from task environment - #1013
Draft
roomote-roomote[bot] wants to merge 2 commits into
Draft
[Feat] Separate model credentials from task environment#1013roomote-roomote[bot] wants to merge 2 commits into
roomote-roomote[bot] wants to merge 2 commits into
Conversation
Contributor
|
1 issue outstanding. See task
Reviewed e0f9cd4 |
Contributor
Author
|
Fixed the live-reload process lifecycle issue in e0f9cd4. Model-runtime changes now update the reconnect spawn environment and immediately restart the harness, so added and revoked credentials take effect in the running model process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this change was made
Model-provider credentials and task environment variables previously shared storage and runtime delivery paths. That allowed generic task configuration to affect Roomote model inference and exposed model credentials more broadly inside task runtimes than necessary.
Impact
Model credentials are now configured and resolved independently from task variables. Existing deployments remain rollback-safe during the compatibility release, while current workers constrain credentials to the model runtime, remove revoked values during live reload, and restart the model process with the refreshed environment.