Skip to content

[Improve] Catch visual inconsistencies in UI proof - #1031

Merged
mrubens merged 1 commit into
developfrom
fix/full-frame-proof-self-check-2saj2d94icahc
Aug 3, 2026
Merged

[Improve] Catch visual inconsistencies in UI proof#1031
mrubens merged 1 commit into
developfrom
fix/full-frame-proof-self-check-2saj2d94icahc

Conversation

@roomote-community

Copy link
Copy Markdown
Contributor

Opened on behalf of sky. Follow up by mentioning @roomote, in the web UI, or in Discord.

Related issue

Not linked; this is an internal maintainer-requested improvement.

Why this PR exists

Visual proof could satisfy a narrow artifact claim while overlooking an obvious defect elsewhere in the captured frame, such as a dark component rendered against a light-themed page.

  • A maintainer explicitly invited this PR in the linked issue or discussion
  • I am a maintainer / this is internal Roomote work

What changed

  • Require proof-runner self-review to inspect both the claimed focal state and the entire captured frame before upload.
  • Check for theme inconsistency, contrast, clipping, broken layout, unintended loading or error states, and styling that conflicts with surrounding UI.
  • Retry capture-caused failures once, but block successful proof when the implementation itself is visually wrong.
  • Cover the expanded self-review contract with a focused prompt regression test.

This makes UI proof stricter and prevents visually inconsistent screenshots from being presented as successful evidence.

How it was tested

  • Ran the focused proof-runner prompt test.
  • Ran worker type checking and formatting checks.
  • Passed the repository pre-push lint, fast type-check, and unused-code gates.

Checklist

  • The PR title follows the repo convention: [Fix], [Feat], [Improve], [Refactor], [Docs], or [Chore] followed by a user-facing description
  • This PR is small and scoped to one change
  • pnpm lint and pnpm check-types pass locally
  • I added tests or included a clear manual validation note above
  • I removed secrets, tokens, private keys, and customer data from code, logs, and screenshots
  • If this change should appear in the changelog, I ran pnpm changeset

@roomote-community

roomote-community Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

No code issues found. See task

Reviewed 8e4a606

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA.
Posted by the CLA Assistant Lite bot.

@easonLiangWorldedtech

Copy link
Copy Markdown
Contributor

I have read the CLA Document and I hereby sign the CLA

github-actions Bot added a commit that referenced this pull request Aug 3, 2026
@roomote-community
roomote-community Bot marked this pull request as ready for review August 3, 2026 15:08
@mrubens
mrubens merged commit 6556126 into develop Aug 3, 2026
19 of 20 checks passed
@mrubens
mrubens deleted the fix/full-frame-proof-self-check-2saj2d94icahc branch August 3, 2026 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants